RESOLVED FIXED 164817
[GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer 
https://bugs.webkit.org/show_bug.cgi?id=164817
Summary [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
Philippe Normand
Reported 2016-11-16 03:11:45 PST
Our OpenWebRTC patches are not upstreamed yet. We also need recent GStreamer for the rtpbin bundling support.
Attachments
patch (4.08 KB, patch)
2016-11-16 03:16 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (4.08 KB, patch)
2016-11-16 04:03 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (54.42 KB, patch)
2016-11-16 07:12 PST, Philippe Normand 		alex: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2016-11-16 03:16:41 PST
Created attachment 294930 [details] patch
Alejandro G. Castro
Comment 2 2016-11-16 03:26:17 PST
Let's do it, I'll let michael or carlos review to make sure it is not bad point.
Philippe Normand
Comment 3 2016-11-16 04:03:09 PST
Created attachment 294931 [details] patch
Philippe Normand
Comment 4 2016-11-16 04:26:53 PST
Comment on attachment 294931 [details] patch I'll ditch openwebrtc.modules again and pick the gst patches we need instead of the drastic bump to gst git master.
Philippe Normand
Comment 5 2016-11-16 07:12:19 PST
Created attachment 294936 [details] patch
Philippe Normand
Comment 6 2016-11-16 07:46:08 PST
Dunno what is up with the EWS, the log is too small.
Philippe Normand
Comment 7 2016-11-16 08:17:39 PST
Cloning into 'gst-plugins-openwebrtc'... done. Fetching origin fatal: reference is not a tree: 9b2199ea970369dbFailed to run "['Tools/Scripts/build-webkit', '--release', '--gtk', '--update-gtk', '--makeargs="-j48"']" exit_code: 1 I suspect the DependenciesGTK/Source/gst-plugins-openwebrtc directory isn't removed beforehand.
Michael Catanzaro
Comment 8 2016-11-16 08:37:55 PST
Comment on attachment 294936 [details] patch EWS is red: Cloning into 'gst-plugins-openwebrtc'... done. Fetching origin fatal: reference is not a tree: 9b2199ea970369dbFailed to run "['Tools/Scripts/build-webkit', '--release', '--gtk', '--update-gtk', '--makeargs="-j48"']" exit_code: 1
Michael Catanzaro
Comment 9 2016-11-16 08:38:23 PST
Looks like I didn't read Phil's comments, sorry :P
Philippe Normand
Comment 10 2016-11-16 08:40:50 PST
I made sure it builds here btw.
Alejandro G. Castro
Comment 11 2016-11-16 22:54:58 PST
It seems a problem with the git pull of the repository, probably it is not removing the directory and adding a new remote does not work. This could cause the same kind of problems in the bots?
Philippe Normand
Comment 12 2016-11-17 00:10:48 PST
(In reply to comment #11) > It seems a problem with the git pull of the repository, probably it is not > removing the directory and adding a new remote does not work. This could > cause the same kind of problems in the bots? I think a clean build is triggered on bots when jhbuild changes, so I think this should be fine.
Philippe Normand
Comment 13 2016-11-21 00:09:31 PST
Committed r208940: <http://trac.webkit.org/changeset/208940>
Note You need to log in before you can comment on or make changes to this bug.