Bug 164776 - [GStreamer][GL] build broken when using gst-plugins-bad from git
Summary: [GStreamer][GL] build broken when using gst-plugins-bad from git
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 164817
  Show dependency tree / graph
 
Reported: 2016-11-15 09:21 PST by Philippe Normand
Modified: 2016-11-16 04:00 PST (History)
3 users (show)

See Also:

Attachments
patch (2.10 KB, patch)
2016-11-15 09:26 PST, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2016-11-15 09:21:21 PST 
../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: In static member function ‘static GstContext* WebCore::MediaPlayerPrivateGStreamerBase::requestGLContext(const gchar*, WebCore::MediaPlayerPrivateGStreamerBase*)’:
../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:310:49: warning: ‘GType GST_GL_TYPE_CONTEXT()’ is deprecated: Use 'GST_TYPE_GL_CONTEXT' instead [-Wdeprecated-declarations]
         gst_structure_set(structure, "context", GST_GL_TYPE_CONTEXT, player->gstGLContext(), nullptr);
                                                 ^~~~~~~~~~~~~~~~~~~
In file included from ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gl/gl.h:33:0,
                 from ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:50:

Will send a patch.
Comment 1 Philippe Normand 2016-11-15 09:26:27 PST 
Created attachment 294843 [details]
patch
Comment 2 Xabier Rodríguez Calvar 2016-11-16 03:39:44 PST 
Comment on attachment 294843 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294843&action=review

> Source/WebCore/ChangeLog:10
> +        GStreamer GL context GType was renamed, add an ifder taking this

ifder.
Comment 3 Philippe Normand 2016-11-16 04:00:29 PST 
Committed r208789: <http://trac.webkit.org/changeset/208789>