Bug 153828 – [Gstreamer] Add volume and mute support to the WebRTC mediaplayer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alejandro G. Castro]

Current mediaplayer implementation does not support volume or mute.

[Philippe Normand]

An OpenWebRTC patch is likely needed for this, see for instance https://github.com/EricssonResearch/openwebrtc/pull/572

[Philippe Normand]

Created attachment 294703 [details]
[OpenWebRTC] audio mute/volume support

Please note this depends on a OpenWebRTC patch not upstream yet.

[Philippe Normand]

See also https://github.com/EricssonResearch/openwebrtc/pull/657

[Darin Adler]

Comment on attachment 294703 [details]
[OpenWebRTC] audio mute/volume support

View in context: https://bugs.webkit.org/attachment.cgi?id=294703&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:108
> +    if (!m_audioTrack)
> +        return;
> +
> +

Extra blank line here.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:109
> +    auto realTimeMediaSource = reinterpret_cast<RealtimeMediaSourceOwr*>(&m_audioTrack->source());

Having to use reinterpret_cast is usually a major danger sign; is there a way to use static_cast in the three places in this file instead?

I suggest making this be a reference instead of a pointer:

    auto& realTimeMediaSource = *some_kind_of_cast<RealtimeMediaSourceOwr&>(m_audioTrack->source());

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:77
> +    void setVolume(float) override;
> +    void setMuted(bool) override;

final instead of override?

[Philippe Normand]

Created attachment 294821 [details]
patch for landing

[Philippe Normand]

Committed r208943: <http://trac.webkit.org/changeset/208943>