Bug 165837 - [GTK] Yasm is needed for building the JHBuild after r208940
Summary: [GTK] Yasm is needed for building the JHBuild after r208940
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks: 164817
  Show dependency tree / graph
 
Reported: 2016-12-13 20:42 PST by Carlos Alberto Lopez Perez
Modified: 2016-12-14 05:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2016-12-13 20:46 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2016-12-13 20:42:25 PST 
After r208940 <http://trac.webkit.org/r208940> Yasm is needed for building libvpx

"--as=yasm" is passed on the configure arguments for libvpx, also see the following build failure for the GTK+ EWS

https://webkit-queues.webkit.org/results/2717072 :
[...]
    [CC] vpx_config.c.o
    [AS] vpx_ports/emms.asm.o
    [AS] vpx_ports/x86_abi_support.asm.o
/bin/sh: 1: yasm: not found
Makefile:179: recipe for target 'vpx_ports/emms.asm.o' failed
make[1]: *** [vpx_ports/emms.asm.o] Error 127

I already installed it on the GTK+ ltilve-ews

But it should be added also on the script Tools/gtk/install-dependencies
Comment 1 Carlos Alberto Lopez Perez 2016-12-13 20:46:33 PST 
Created attachment 297061 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-14 05:42:06 PST 
Comment on attachment 297061 [details]
Patch

Clearing flags on attachment: 297061

Committed r209799: <http://trac.webkit.org/changeset/209799>
Comment 3 WebKit Commit Bot 2016-12-14 05:42:10 PST 
All reviewed patches have been landed.  Closing bug.