Bug 164678 – Web Inspector: Should be able to display a name for a Worker

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Should be able to display a name for a Worker

Websites may spawn multiple workers with the same URL but use them for different purposes. It would be nice to name the Worker, such as setting a `name` or `displayName` property on the Worker object from the Page.

    var worker1 = new Worker("worker.js")
    worker1.name = "Foo Worker";

    var worker2 = new Worker("worker.js");
    worker2.name = "Bar Worker";

This could be similar to the `displayName` convention debuggers use with functions.
http://www.alertdebugging.com/2009/04/29/building-a-better-javascript-profiler-with-webkit/

[Radar WebKit Bug Importer]

<rdar://problem/29233008>

[Joseph Pecoraro]

Created attachment 294810 [details]
[PATCH] Proposed Fix

This adds a `attribute DOMString name;` to Worker.idl. I'll have to discuss how/if we should go about standardizing this.

[Joseph Pecoraro]

Created attachment 294811 [details]
[IMAGE] Named Workers

Sidebar shows Named and Unnamed workers (defaults to a display name for the URL).

[Joseph Pecoraro]

Comment on attachment 294810 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=294810&action=review

> Source/WebInspectorUI/UserInterface/Views/WorkerTreeElement.js:175
> +    _nameUpdated(event)
> +    {
> +        this._updateTitles();
> +    }

When this happens we need to resort this among its siblings.

Also if Thread Line Indicators land this patch would need to be updated to update those.

[Joseph Pecoraro]

Going to clear the review on the until we go through some standardization process.

I'm also going to break out useful parts of this (Like moving WorkerTarget and MainTarget into their own file) as cleanup now, because I liked it and I've been missing it!

[Joseph Pecoraro]

Looks like this made standardization progress:
https://github.com/whatwg/html/issues/2477
https://github.com/whatwg/html/pull/2664#issuecomment-300692176

Solution was a name property on an options dictionary:

    var worker = new Worker("worker.js", {name: "Foo Worker"});

I think it also sets the `self.name` within the Worker scope.

    assert( self.name === "Foo Worker" );

So, I should be able to move forward with this.

[Devin Rousso]

*** This bug has been marked as a duplicate of bug 211244 ***

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #7)
> 
> *** This bug has been marked as a duplicate of bug 211244 ***

\o/