Bug 211244 – Web Inspector: Worker: should use the name of the worker if it exists

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

test.html
```
let worker = new Worker("worker.js", {name: "My Worker"});
```

worker.js
```
console.log(self.name);
```

[Devin Rousso]

Created attachment 398084 [details]
Patch

[EWS Watchlist]

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

[Blaze Burg]

Comment on attachment 398084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398084&action=review

r=me great cleanup!

Please investigate Windows EWS failure:

C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\JavaScriptCore/InspectorFrontendDispatchers.h(351,10): message : see declaration of 'Inspector::WorkerFrontendDispatcher::workerCreated' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-6.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]

> LayoutTests/inspector/worker/runtime-basic-expected.txt:13
>  Target - Page - location and href - Location: inspector/worker/runtime-basic.html
>  

Very nice!

[Devin Rousso]

(In reply to Brian Burg from comment #3)
> Please investigate Windows EWS failure:
> 
> C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\JavaScriptCore/InspectorFrontendDispatchers.h(351,10): message : see declaration of 'Inspector::WorkerFrontendDispatcher::workerCreated' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-6.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]

The windows bot doesn't seem to update/regenerate DerivedSources properly.  This has happened a bunch of times when I've made changes to the protocol.  A clean build has always fixed the issue.

[Devin Rousso]

*** Bug 164678 has been marked as a duplicate of this bug. ***

[EWS]

Committed r261104: <https://trac.webkit.org/changeset/261104>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398084 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62857411>