Bug 188779 – Support "name" option for dedicated workers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

Support "name" option for dedicated workers

[Yusuke Suzuki]

Created attachment 347613 [details]
Patch

[EWS Watchlist]

Attachment 347613 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 347614 [details]
Patch

[EWS Watchlist]

Attachment 347614 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 347618 [details]
Patch

[Yusuke Suzuki]

*** Bug 172016 has been marked as a duplicate of this bug. ***

[EWS Watchlist]

Attachment 347618 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 347618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347618&action=review

r=me!

> Source/WebCore/ChangeLog:14
> +        [2]: https://bugs.webkit.org/show_bug.cgi?id=164678

Yep! I have been looking forward to this for a while, thanks!

[Joseph Pecoraro]

Would it be worth a test of our own for Worker names, or should we just rely on the WPTs?

[Yusuke Suzuki]

(In reply to Joseph Pecoraro from comment #9)
> Would it be worth a test of our own for Worker names, or should we just rely
> on the WPTs?

We can add tests additionally! I'll add several ones :)

[Yusuke Suzuki]

Committed r235128: <https://trac.webkit.org/changeset/235128>

[Radar WebKit Bug Importer]

<rdar://problem/43570680>

[Truitt Savell]

The new test:
http/wpt/workers/name-property-enhanced.html

From patch:
<https://trac.webkit.org/changeset/235128>

Is flakey and failed on most builds:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fworkers%2Fname-property-enhanced.html

[Joseph Pecoraro]

> Is flakey and failed on most builds:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=http%2Fwpt%2Fworkers%2Fname-property-enhanced.
> html

Thanks for the heads up.

Do you file bugzilla bugs on these failures? What is the failure diff? It requires a lot of clicks from the slow loading flakiness dashboard to act!

[Joseph Pecoraro]

Looks like the failure is out of order results:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r235128%20(12237)/results.html

> --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/http/wpt/workers/name-property-enhanced-expected.txt
> +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/http/wpt/workers/name-property-enhanced-actual.txt
> @@ -2,7 +2,7 @@
>  Harness Error (FAIL), message = 2 duplicate test names: "name property value for DedicatedWorkerGlobalScope", "name property is replaceable for DedicatedWorkerGlobalScope"
>  
>  PASS name property value for DedicatedWorkerGlobalScope 
> -PASS name property is replaceable for DedicatedWorkerGlobalScope 
>  PASS name property value for DedicatedWorkerGlobalScope 
>  PASS name property is replaceable for DedicatedWorkerGlobalScope 
> +PASS name property is replaceable for DedicatedWorkerGlobalScope

[Joseph Pecoraro]

Maybe in WPT fetch_tests_from_worker(...) might run tests in parallel instead of serial?

[Ryan Haddad]

This test is failing more often than it is passing on the bots and is slowing down EWS.

We should roll this out if it needs more investigation.

[Ryan Haddad]

Reverted r235128 for reason:

The test added with this change is frequently failing.

Committed r235155: <https://trac.webkit.org/changeset/235155>

[Yusuke Suzuki]

Committed r235159: <https://trac.webkit.org/changeset/235159>

[Yusuke Suzuki]

Thanks, I've relanded the patch by splitting the test into 2 files to make it deterministic!