Bug 164217 - Should we remove legacy RTCPeerConnection callback API?
Summary: Should we remove legacy RTCPeerConnection callback API?
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency treegraph
 
Reported: 2016-10-31 01:00 PDT by youenn fablet
Modified: 2017-03-16 14:21 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-31 01:00:18 PDT
Is it time to remove RTCPeerConnection callback API?
Comment 1 Adam Bergkvist 2016-10-31 01:36:35 PDT
I don't think we can do that. These callbacks are also documented in the spec [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160913/webrtc.html#legacy-interface-extensions
Comment 2 Alex. Gouaillard 2016-11-01 07:01:01 PDT
You cannot remove the API, but the specs leaves the freedom to make it but a wrapper around the promise API leaving only one implementation to maintain. See how navigator.getUserMedia is implemented (vs MediaDevices.getUserMedia)
Comment 3 Adam Bergkvist 2016-11-01 07:22:19 PDT
(In reply to comment #2)
> You cannot remove the API, but the specs leaves the freedom to make it but a
> wrapper around the promise API leaving only one implementation to maintain.
> See how navigator.getUserMedia is implemented (vs MediaDevices.getUserMedia)

This is how the RTCPeerConnection legacy callback API is implemented currently as well.
Comment 4 Jon Lee 2017-01-30 09:39:31 PST
Is there anything left here? Should we close this as WONTFIX?
Comment 5 youenn fablet 2017-01-30 12:03:05 PST
I am not sure this is WONTFIX.
WebKit hasn't shipped yet the feature so we have some freedom here.

The legacy APIs are wrappers around the promise-based APIs which are also evolving.
Probably legacy services need to be updated according these internal changes so I would think they could/are migrating to promise-based APIs.
Comment 6 youenn fablet 2017-01-30 15:54:35 PST
WebRTC WG recently removed getStats legacy API.
We should at least do that.