Bug 169646 - Wrap legacy WebRTC API in runtime flag
Summary: Wrap legacy WebRTC API in runtime flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 169662
  Show dependency tree / graph
 
Reported: 2017-03-14 16:56 PDT by Jon Lee
Modified: 2017-03-16 17:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (24.09 KB, patch)
2017-03-16 14:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing build (24.12 KB, patch)
2017-03-16 15:22 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2017-03-14 16:56:49 PDT 
Wrap legacy WebRTC API in runtime flag
Comment 1 youenn fablet 2017-03-16 14:33:59 PDT 
Created attachment 304694 [details]
Patch
Comment 2 youenn fablet 2017-03-16 14:36:11 PDT 
Patch is adding a runtime flag for the legacy API.
Turned on by default from now.

Also found that the overload for createOffer and createAnswer is not inline with the spec (parameters/order of parameters).
Comment 3 youenn fablet 2017-03-16 15:22:55 PDT 
Created attachment 304704 [details]
Fixing build
Comment 4 WebKit Commit Bot 2017-03-16 17:05:41 PDT 
Comment on attachment 304704 [details]
Fixing build

Clearing flags on attachment: 304704

Committed r214080: <http://trac.webkit.org/changeset/214080>
Comment 5 WebKit Commit Bot 2017-03-16 17:05:49 PDT 
All reviewed patches have been landed.  Closing bug.