Bug 167617 - [WebRTC] getStats does not support legacy callback
Summary: [WebRTC] getStats does not support legacy callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-30 17:26 PST by youenn fablet
Modified: 2017-02-10 00:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (23.74 KB, patch)
2017-01-30 17:27 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-01-30 17:26:25 PST 
[WebRTC] getStats does not support legacy callback
Comment 1 youenn fablet 2017-01-30 17:27:40 PST 
Created attachment 300167 [details]
Patch
Comment 2 youenn fablet 2017-01-30 17:28:47 PST 
Comment on attachment 300167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300167&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt:-11
> -PASS promise RTCPeerConnection.prototype.getStats.call({}, null) rejected with TypeError: Function should be called on an RTCPeerConnection

I did not change this test as I propose to replace it by another one in bug 167571
Comment 3 WebKit Commit Bot 2017-01-30 20:35:50 PST 
Comment on attachment 300167 [details]
Patch

Clearing flags on attachment: 300167

Committed r211404: <http://trac.webkit.org/changeset/211404>
Comment 4 WebKit Commit Bot 2017-01-30 20:35:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Bergkvist 2017-02-09 07:56:29 PST 
But getStats *is* listed in the Legacy Interface Extensions section [1].

[1] https://w3c.github.io/webrtc-pc/archives/20161219/webrtc.html#legacy-interface-extensions
Comment 6 Adam Bergkvist 2017-02-10 00:03:13 PST 
Please disregard from my last comment.