* SUMMARY Show content tree outline records in timeline data grids. The new design eliminates the navigation side bar. Add a new first column with disclosure triangles enabled (except for the Network timeline), and duplicate the data currently shown in the content tree outline.
<rdar://problem/24195317>
Created attachment 270768 [details] [Patch] Proposed Fix
Created attachment 270769 [details] [Image] OverviewTimelineView grid Graph column w/ TimelineRuler header cell.
Created attachment 270770 [details] [Image] NetworkTimelineView grid Goto arrow buttons supported in the first column.
Created attachment 270771 [details] [Image] RenderingFrameTimelineView grid Frames graph stretches across entire view.
Comment on attachment 270768 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270768&action=review > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:53 > eventType: this._record.eventType, Should this be removed? > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:74 > + return value; Should this be: return WebInspector.LayoutTimelineRecord.displayNameForEventType(value);
(In reply to comment #6) > Comment on attachment 270768 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270768&action=review > > > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:53 > > eventType: this._record.eventType, > > Should this be removed? Yes, nice catch. > > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:74 > > + return value; > > Should this be: return > WebInspector.LayoutTimelineRecord.displayNameForEventType(value); The value is formatted once, when creating the cached data. No need to reformat.
Created attachment 271457 [details] [Patch] Proposed Fix
Created attachment 272693 [details] [Patch] Proposed Fix
Comment on attachment 272693 [details] [Patch] Proposed Fix Rejecting attachment 272693 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 272693, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: InspectorUI/UserInterface/Views/ScriptTimelineView.js patching file Source/WebInspectorUI/UserInterface/Views/SourceCodeTimelineTimelineDataGridNode.js patching file Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js patching file Source/WebInspectorUI/UserInterface/Views/TimelineView.css patching file Source/WebInspectorUI/UserInterface/Views/Variables.css Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/913228
Created attachment 272715 [details] [Patch] Proposed Fix
Committed r197487: <https://trac.webkit.org/r197487>
Comment on attachment 272715 [details] [Patch] Proposed Fix Rejecting attachment 272715 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 272715, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: s). 4 out of 5 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js.rej patching file Source/WebInspectorUI/UserInterface/Views/TimelineView.css Hunk #1 succeeded at 36 with fuzz 1 (offset 5 lines). patching file Source/WebInspectorUI/UserInterface/Views/Variables.css Hunk #1 succeeded at 51 with fuzz 2 (offset 2 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/913849