WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153032
Web Inspector: Timelines UI redesign: show content tree outline records in timeline data grids
https://bugs.webkit.org/show_bug.cgi?id=153032
Summary
Web Inspector: Timelines UI redesign: show content tree outline records in ti...
Matt Baker
Reported
2016-01-12 12:50:12 PST
* SUMMARY Show content tree outline records in timeline data grids. The new design eliminates the navigation side bar. Add a new first column with disclosure triangles enabled (except for the Network timeline), and duplicate the data currently shown in the content tree outline.
Attachments
[Patch] Proposed Fix
(42.67 KB, patch)
2016-02-05 14:07 PST
,
Matt Baker
no flags
Details
Formatted Diff
Diff
[Image] OverviewTimelineView grid
(256.62 KB, image/png)
2016-02-05 14:14 PST
,
Matt Baker
no flags
Details
[Image] NetworkTimelineView grid
(458.95 KB, image/png)
2016-02-05 14:15 PST
,
Matt Baker
no flags
Details
[Image] RenderingFrameTimelineView grid
(334.92 KB, image/png)
2016-02-05 14:17 PST
,
Matt Baker
no flags
Details
[Patch] Proposed Fix
(42.67 KB, patch)
2016-02-16 11:29 PST
,
Matt Baker
no flags
Details
Formatted Diff
Diff
[Patch] Proposed Fix
(42.61 KB, patch)
2016-03-02 15:23 PST
,
Matt Baker
no flags
Details
Formatted Diff
Diff
[Patch] Proposed Fix
(42.79 KB, patch)
2016-03-02 17:55 PST
,
Matt Baker
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-01-14 14:24:07 PST
<
rdar://problem/24195317
>
Matt Baker
Comment 2
2016-02-05 14:07:22 PST
Created
attachment 270768
[details]
[Patch] Proposed Fix
Matt Baker
Comment 3
2016-02-05 14:14:40 PST
Created
attachment 270769
[details]
[Image] OverviewTimelineView grid Graph column w/ TimelineRuler header cell.
Matt Baker
Comment 4
2016-02-05 14:15:51 PST
Created
attachment 270770
[details]
[Image] NetworkTimelineView grid Goto arrow buttons supported in the first column.
Matt Baker
Comment 5
2016-02-05 14:17:07 PST
Created
attachment 270771
[details]
[Image] RenderingFrameTimelineView grid Frames graph stretches across entire view.
Timothy Hatcher
Comment 6
2016-02-05 14:53:08 PST
Comment on
attachment 270768
[details]
[Patch] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=270768&action=review
> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:53 > eventType: this._record.eventType,
Should this be removed?
> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:74 > + return value;
Should this be: return WebInspector.LayoutTimelineRecord.displayNameForEventType(value);
Matt Baker
Comment 7
2016-02-16 11:24:26 PST
(In reply to
comment #6
)
> Comment on
attachment 270768
[details]
> [Patch] Proposed Fix > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=270768&action=review
> > > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:53 > > eventType: this._record.eventType, > > Should this be removed?
Yes, nice catch.
> > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:74 > > + return value; > > Should this be: return > WebInspector.LayoutTimelineRecord.displayNameForEventType(value);
The value is formatted once, when creating the cached data. No need to reformat.
Matt Baker
Comment 8
2016-02-16 11:29:37 PST
Created
attachment 271457
[details]
[Patch] Proposed Fix
Matt Baker
Comment 9
2016-03-02 15:23:53 PST
Created
attachment 272693
[details]
[Patch] Proposed Fix
WebKit Commit Bot
Comment 10
2016-03-02 17:27:28 PST
Comment on
attachment 272693
[details]
[Patch] Proposed Fix Rejecting
attachment 272693
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 272693, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: InspectorUI/UserInterface/Views/ScriptTimelineView.js patching file Source/WebInspectorUI/UserInterface/Views/SourceCodeTimelineTimelineDataGridNode.js patching file Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js patching file Source/WebInspectorUI/UserInterface/Views/TimelineView.css patching file Source/WebInspectorUI/UserInterface/Views/Variables.css Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/913228
Matt Baker
Comment 11
2016-03-02 17:55:02 PST
Created
attachment 272715
[details]
[Patch] Proposed Fix
Matt Baker
Comment 12
2016-03-02 19:47:08 PST
Committed
r197487
: <
https://trac.webkit.org/r197487
>
WebKit Commit Bot
Comment 13
2016-03-02 20:30:39 PST
Comment on
attachment 272715
[details]
[Patch] Proposed Fix Rejecting
attachment 272715
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 272715, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: s). 4 out of 5 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js.rej patching file Source/WebInspectorUI/UserInterface/Views/TimelineView.css Hunk #1 succeeded at 36 with fuzz 1 (offset 5 lines). patching file Source/WebInspectorUI/UserInterface/Views/Variables.css Hunk #1 succeeded at 51 with fuzz 2 (offset 2 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/913849
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug