* SUMMARY DataGridNode should support adding go-to arrow buttons to any cell. TimelineDataGridNode automatically creates go-to arrows for SourceCodeLocation cells, but currently it's not convenient to add go-to arrows to arbitrary cells. As part of the Timelines UI redesign, grids will need cells with arrow buttons for navigating to resources: https://bugs.webkit.org/show_bug.cgi?id=153032.
<rdar://problem/24431813>
Created attachment 270363 [details] [Patch] Proposed Fix
Comment on attachment 270363 [details] [Patch] Proposed Fix r=me
Comment on attachment 270363 [details] [Patch] Proposed Fix Clearing flags on attachment: 270363 Committed r195966: <http://trac.webkit.org/changeset/195966>
All reviewed patches have been landed. Closing bug.
Comment on attachment 270363 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270363&action=review > Source/WebInspectorUI/ChangeLog:10 > + Provide a way to add go-to arrow buttons to any grid cell from within a > + DataGridNode subclass's implementation of createCellContent. Why? I think of DataGrid as a table containing cells. In which case: - Most DataGrids will not require this, so it shouldn't be in the base class. - When there are goto arrows, I prefer they have a sourceCodeLocation and so can provide a tooltip - Placement of the goto arrow may be different depending on what the cell wants. - If a cell manually creates its own goto arrow, the DataGrid's GoToArrowClicked is not triggered. That seems confusing.
(In reply to comment #6) > Comment on attachment 270363 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270363&action=review > > > Source/WebInspectorUI/ChangeLog:10 > > + Provide a way to add go-to arrow buttons to any grid cell from within a > > + DataGridNode subclass's implementation of createCellContent. > > Why? > > I think of DataGrid as a table containing cells. In which case: > > - Most DataGrids will not require this, so it shouldn't be in the base class. > - When there are goto arrows, I prefer they have a sourceCodeLocation and so > can provide a tooltip Currently goto arrows are only created for SourceCodeLocation's but this will be changing. Cells in the 'Name' column created by ResourceDataGridNode (https://webkit.org/b/153034) needs a goto arrow, but don't have SourceCodeLocations. It's up to the NetworkTimeView/OverviewTimelineView to handle the grid's GoToArrowClicked event and open a content view for the node's resource. This is similar to what the TimelineSidebarPanel does now. > - Placement of the goto arrow may be different depending on what the cell > wants. It seems like right-aligned goto arrows is pretty standard throughout the UI (SourceCodeLocation cells, tree elements). > - If a cell manually creates its own goto arrow, the DataGrid's > GoToArrowClicked is not triggered. That seems confusing. I agree that this is somewhat confusing.