Bug 153756 - Web Inspector: DataGridNode should support adding/removing a status element to any cell
Summary: Web Inspector: DataGridNode should support adding/removing a status element t...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 153032
  Show dependency treegraph
 
Reported: 2016-02-01 13:09 PST by Matt Baker
Modified: 2016-12-13 15:41 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-02-01 13:09:25 PST
* SUMMARY
DataGridNode should support adding/removing a status element to any cell.

As part of the Timelines UI redesign, grids will need cells with status elements, so the Network and Overview grids can display an IndeterminateProgressSpinner for loading resources.
Comment 1 Radar WebKit Bug Importer 2016-02-01 13:09:52 PST
<rdar://problem/24444108>
Comment 2 Joseph Pecoraro 2016-02-01 13:11:50 PST
Again, this sounds to me like something that should go inside a cell itself, instead of DataGridNode. We already have TimelineDataGridNode, perhaps these should be going in there?
Comment 3 Matt Baker 2016-02-01 13:25:43 PST
(In reply to comment #2)
> Again, this sounds to me like something that should go inside a cell itself,
> instead of DataGridNode. We already have TimelineDataGridNode, perhaps these
> should be going in there?

Not sure what you mean by placing it "in the cell itself", since we deal in grid nodes/rows, not cells.

I like placing it in DataGridNode, since it feels like basic functionality which could have utility outside the timeline grids (even though TimelineDataGridNode is the only use case as of now).