Bug 153387 - Web Inspector: add support for placing Views in DataGrid column headers
Summary: Web Inspector: add support for placing Views in DataGrid column headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 153032
  Show dependency tree / graph
 
Reported: 2016-01-22 17:59 PST by Matt Baker
Modified: 2016-01-24 20:00 PST (History)
8 users (show)

See Also:

Attachments
[Image] OverviewTimelineView with ruler column header (222.49 KB, image/png)
2016-01-22 17:59 PST, Matt Baker 		no flags Details
[Patch] Proposed Fix (3.05 KB, patch)
2016-01-22 19:39 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (5.60 KB, patch)
2016-01-24 17:04 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-01-22 17:59:31 PST 
Created attachment 269628 [details]
[Image] OverviewTimelineView with ruler column header

* SUMMARY
Add support for placing Views in DataGrid column headers. DataGrid already provides a column property `titleDOMFragment` for using custom DOM content in place of simple title text content. The ability to place a TimelineRuler inside a header cell is needed to mix normal grid columns with the "graph only" grid column used in OverviewTimelineView's data grid.

See attached screenshot.
Comment 1 Radar WebKit Bug Importer 2016-01-22 17:59:46 PST 
<rdar://problem/24310797>
Comment 2 Matt Baker 2016-01-22 19:39:01 PST 
Created attachment 269633 [details]
[Patch] Proposed Fix
Comment 3 Matt Baker 2016-01-22 19:53:08 PST 
There are perf issues with this patch. None that I noticed whole ad hoc testing, but as written DataGrid will call offsetWidth many more times that previously, even if no column header cells are hosting Views. Will fix momentarily.
Comment 4 Matt Baker 2016-01-24 17:04:37 PST 
Created attachment 269707 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-01-24 20:00:47 PST 
Comment on attachment 269707 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 269707

Committed r195522: <http://trac.webkit.org/changeset/195522>
Comment 6 WebKit Commit Bot 2016-01-24 20:00:51 PST 
All reviewed patches have been landed.  Closing bug.