Bug 149243 - Make event dispatching respect slotting
Summary: Make event dispatching respect slotting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
: 149324 (view as bug list)
Depends on: 149241 149488
Blocks: 148695
  Show dependency tree / graph
 
Reported: 2015-09-16 18:13 PDT by Ryosuke Niwa
Modified: 2015-09-29 10:54 PDT (History)
6 users (show)

See Also:

Attachments
Implements the basic dispatching (32.97 KB, patch)
2015-09-23 18:21 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (33.02 KB, patch)
2015-09-24 11:08 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-16 18:13:07 PDT 
Make event dispatching code respect the slotting added in the bug 149241.
Comment 1 Radar WebKit Bug Importer 2015-09-17 18:12:03 PDT 
<rdar://problem/22750923>
Comment 2 Ryosuke Niwa 2015-09-19 02:14:27 PDT 
*** Bug 149324 has been marked as a duplicate of this bug. ***
Comment 3 Ryosuke Niwa 2015-09-23 18:21:34 PDT 
Created attachment 261857 [details]
Implements the basic dispatching
Comment 4 Andreas Kling 2015-09-24 10:14:51 PDT 
Comment on attachment 261857 [details]
Implements the basic dispatching

View in context: https://bugs.webkit.org/attachment.cgi?id=261857&action=review

r=me too

> Source/WebCore/dom/EventDispatcher.cpp:433
> +        Node* parent;

Could this be a ContainerNode*?

> Source/WebCore/dom/EventDispatcher.cpp:451
> +                if (auto assignedSlot = shadowRootOfParent->findAssignedSlot(*node)) {

We use auto* for pointers rather than auto, I think.

> Source/WebCore/dom/EventDispatcher.cpp:452
> +                    // node is assgined to a slot. Continue dispatching the event at this slot.

Typo, assigned.
Comment 5 Ryosuke Niwa 2015-09-24 11:08:59 PDT 
Created attachment 261877 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-09-24 12:00:32 PDT 
Comment on attachment 261877 [details]
Patch for landing

Clearing flags on attachment: 261877

Committed r190214: <http://trac.webkit.org/changeset/190214>
Comment 7 WebKit Commit Bot 2015-09-24 12:00:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Brent Fulgham 2015-09-29 10:54:26 PDT 
This change *may* have introduced Windows regressions (see https://bugs.webkit.org/show_bug.cgi?id=149632).