Bug 149243 – Make event dispatching respect slotting

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Ryosuke Niwa]

Make event dispatching code respect the slotting added in the bug 149241.

[Radar WebKit Bug Importer]

<rdar://problem/22750923>

[Ryosuke Niwa]

*** Bug 149324 has been marked as a duplicate of this bug. ***

[Ryosuke Niwa]

Created attachment 261857 [details]
Implements the basic dispatching

[Andreas Kling]

Comment on attachment 261857 [details]
Implements the basic dispatching

View in context: https://bugs.webkit.org/attachment.cgi?id=261857&action=review

r=me too

> Source/WebCore/dom/EventDispatcher.cpp:433
> +        Node* parent;

Could this be a ContainerNode*?

> Source/WebCore/dom/EventDispatcher.cpp:451
> +                if (auto assignedSlot = shadowRootOfParent->findAssignedSlot(*node)) {

We use auto* for pointers rather than auto, I think.

> Source/WebCore/dom/EventDispatcher.cpp:452
> +                    // node is assgined to a slot. Continue dispatching the event at this slot.

Typo, assigned.

[Ryosuke Niwa]

Created attachment 261877 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 261877 [details]
Patch for landing

Clearing flags on attachment: 261877

Committed r190214: <http://trac.webkit.org/changeset/190214>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

This change *may* have introduced Windows regressions (see https://bugs.webkit.org/show_bug.cgi?id=149632).