Bug 149241 – Add HTMLSlotElement, Element.slot, and NonDocumentTypeChildNode.assignedSlot

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Add the support for slotting.

[Radar WebKit Bug Importer]

<rdar://problem/22732247>

[Radar WebKit Bug Importer]

<rdar://problem/22732252>

[Ryosuke Niwa]

Created attachment 261361 [details]
EWS test

[Ryosuke Niwa]

Created attachment 261362 [details]
EFL fix attempt

[Antti Koivisto]

Comment on attachment 261362 [details]
EFL fix attempt

View in context: https://bugs.webkit.org/attachment.cgi?id=261362&action=review

> Source/WebCore/dom/ShadowRoot.cpp:155
> +    RELEASE_ASSERT(m_slotAssignments);
> +    return m_slotAssignments->removeSlotElementByName(name, slot);

No need for RELEASE_ASSERT, this is going to crash with clean(ish) null if it fails.

> Source/WebCore/dom/ShadowRoot.cpp:158
> +void ShadowRoot::setNeedsReslotting()

"Reslotting" is bit strange. Maybe invalidateSlotAssignments()?

> Source/WebCore/dom/ShadowRoot.cpp:161
> +        m_slotAssignments->setNeedsReslotting();

...and just invalidate()

> Source/WebCore/dom/ShadowRoot.h:87
> +    const Vector<Node*>* assignedNodesForSlot(const HTMLSlotElement&);
> +
> +#endif

Unnecessary empty line.

> Source/WebCore/dom/SlotAssignment.h:78
> +    bool m_needsToResolveSlotElemenets { false };

Spelling "Elemenets"

[Ryosuke Niwa]

Created attachment 261363 [details]
EFL fix attempt 2

[Build Bot]

Comment on attachment 261363 [details]
EFL fix attempt 2

Attachment 261363 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/178356

New failing tests:
fast/shadow-dom/HTMLSlotElement-interface.html

[Build Bot]

Created attachment 261367 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 261363 [details]
EFL fix attempt 2

Attachment 261363 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/178476

New failing tests:
fast/shadow-dom/HTMLSlotElement-interface.html

[Build Bot]

Created attachment 261374 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Ryosuke Niwa]

Comment on attachment 261363 [details]
EFL fix attempt 2

View in context: https://bugs.webkit.org/attachment.cgi?id=261363&action=review

> Source/WebCore/html/HTMLSlotElement.cpp:49
> +    ASSERT_UNUSED(insertionPoint, HTMLElement::insertedInto(insertionPoint) == InsertionDone);

Fuck, another case of not calling in release builds :(

[Ryosuke Niwa]

Created attachment 261378 [details]
Ready for review

[Ryosuke Niwa]

Created attachment 261379 [details]
Reverted changes to WebKit.xcworkspace

[Antti Koivisto]

Comment on attachment 261379 [details]
Reverted changes to WebKit.xcworkspace

View in context: https://bugs.webkit.org/attachment.cgi?id=261379&action=review

> Source/WebCore/dom/SlotAssignment.h:66
> +        unsigned count { 0 };

This could use a more descriptive name. This is the count of equivalent (same name) slot elements in the shadow tree if I understand correctly. Maybe duplicateSlotElementCount or something?

> Source/WebCore/dom/SlotAssignment.h:74
> +    HashMap<AtomicString, SlotInfo> m_slots;

You might consider <AtomicString, std::unique_ptr<SlotInfo>> instead. SlotInfo can be large and rehashing involves copying.

With that the struct definition can be in cpp too.

[Ryosuke Niwa]

Committed r189950: <http://trac.webkit.org/changeset/189950>