Bug 149244 - removeShadow shouldn't call ChildNodeRemovalNotifier with the shadow host as the removal point
Summary: removeShadow shouldn't call ChildNodeRemovalNotifier with the shadow host as ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 149241
  Show dependency treegraph
 
Reported: 2015-09-16 18:27 PDT by Ryosuke Niwa
Modified: 2015-09-16 23:12 PDT (History)
10 users (show)

See Also:


Attachments
Fixes the bug (3.48 KB, patch)
2015-09-16 18:41 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (838.28 KB, application/zip)
2015-09-16 19:40 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-mavericks (885.29 KB, application/zip)
2015-09-16 19:59 PDT, Build Bot
no flags Details
Fixed the bug (3.53 KB, patch)
2015-09-16 21:37 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-16 18:27:48 PDT
Since the shadow host is in a different tree than nodes in its shadow tree,
it's incorrect to call removedFrom with the shadow host as the removal point.

This bug was revealed while working on the bug 149241.
Comment 1 Ryosuke Niwa 2015-09-16 18:41:31 PDT
Created attachment 261347 [details]
Fixes the bug
Comment 2 Build Bot 2015-09-16 19:40:03 PDT
Comment on attachment 261347 [details]
Fixes the bug

Attachment 261347 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/178029

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-09-16 19:40:08 PDT
Created attachment 261353 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-09-16 19:59:44 PDT
Comment on attachment 261347 [details]
Fixes the bug

Attachment 261347 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/178071

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-09-16 19:59:49 PDT
Created attachment 261356 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Ryosuke Niwa 2015-09-16 21:00:25 PDT
Okay, I don't think these failures are related to my patch.
Comment 7 Ryosuke Niwa 2015-09-16 21:34:26 PDT
Comment on attachment 261347 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=261347&action=review

> Source/WebCore/dom/Element.cpp:1618
> +    ASSERT(shadowRoot.insertedInto(*this) == InsertionDone);

Oh snap, I'm not calling this function in a Release build :(
Comment 8 Ryosuke Niwa 2015-09-16 21:37:08 PDT
Created attachment 261364 [details]
Fixed the bug
Comment 9 WebKit Commit Bot 2015-09-16 23:12:21 PDT
Comment on attachment 261364 [details]
Fixed the bug

Clearing flags on attachment: 261364

Committed r189906: <http://trac.webkit.org/changeset/189906>
Comment 10 WebKit Commit Bot 2015-09-16 23:12:27 PDT
All reviewed patches have been landed.  Closing bug.