NEW 135290
Rename FontData and friends to better names 
https://bugs.webkit.org/show_bug.cgi?id=135290
Summary Rename FontData and friends to better names
Myles C. Maxfield
Reported 2014-07-25 08:35:59 PDT
Font represents a CSS font, not a platform font. A FontData is either one or a collection of SimpleFontData objects. SimpleFontData has a function called fontData() which returns AdditionalFontData and a member variable of type DerivedFontData. These names are confusing.
Attachments
Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-01-06 03:48:52 PST
Maybe something like: Font -> CompositeFont SimpleFontData -> Font SegmentedFontData -> SegmentedFont FontData -> FontBase (eliminating the inheritance here would be good) AdditionalFontData -> SVGFontCallback (no need to be coy) SimpleFontData::fontData() -> SimpleFontData::svgFontCallback()
Note You need to log in before you can comment on or make changes to this bug.