Bug 135290 - Rename FontData and friends to better names
Summary: Rename FontData and friends to better names
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on: 140124 140442 140496
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-25 08:35 PDT by Myles C. Maxfield
Modified: 2015-01-15 07:34 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-07-25 08:35:59 PDT 
Font represents a CSS font, not a platform font. A FontData is either one or a collection of SimpleFontData objects. SimpleFontData has a function called fontData() which returns AdditionalFontData and a member variable of type DerivedFontData. These names are confusing.
Comment 1 Antti Koivisto 2015-01-06 03:48:52 PST 
Maybe something like:

Font -> CompositeFont 
SimpleFontData -> Font
SegmentedFontData -> SegmentedFont
FontData -> FontBase (eliminating the inheritance here would be good)
AdditionalFontData -> SVGFontCallback (no need to be coy)
SimpleFontData::fontData() -> SimpleFontData::svgFontCallback()