Bug 140124 - Rename SimpleFontData::AdditionalFontData to SimpleFontData::SVGData
Summary: Rename SimpleFontData::AdditionalFontData to SimpleFontData::SVGData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 135290
  Show dependency tree / graph
 
Reported: 2015-01-06 07:32 PST by Antti Koivisto
Modified: 2015-01-06 11:22 PST (History)
11 users (show)

See Also:

Attachments
patch (10.43 KB, patch)
2015-01-06 07:45 PST, Antti Koivisto 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-01-06 07:32:34 PST 
The current name is vague and confusing.
Comment 1 Antti Koivisto 2015-01-06 07:45:40 PST 
Created attachment 244061 [details]
patch
Comment 2 Myles C. Maxfield 2015-01-06 09:39:37 PST 
Comment on attachment 244061 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244061&action=review

> Source/WebCore/platform/graphics/SimpleFontData.h:179
> +    bool isSVGFont() const { return !!m_svgData; }

Is the !! necessary? Won't the bool cast be automatic?
Comment 3 Anders Carlsson 2015-01-06 09:41:38 PST 
Comment on attachment 244061 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244061&action=review

>> Source/WebCore/platform/graphics/SimpleFontData.h:179
>> +    bool isSVGFont() const { return !!m_svgData; }
> 
> Is the !! necessary? Won't the bool cast be automatic?

It won't since the std::unique_ptr bool operator is explicit.
Comment 4 Antti Koivisto 2015-01-06 11:22:12 PST 
https://trac.webkit.org/r177975