Bug 140496 - Rename SimpleFontData to Font
Summary: Rename SimpleFontData to Font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 140814
Blocks: 135290
  Show dependency treegraph
 
Reported: 2015-01-15 07:34 PST by Antti Koivisto
Modified: 2015-01-23 00:25 PST (History)
5 users (show)

See Also:


Attachments
patch (394.83 KB, patch)
2015-01-15 10:55 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (478.64 KB, patch)
2015-01-15 11:14 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (316.09 KB, patch)
2015-01-21 16:08 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
another (322.54 KB, patch)
2015-01-21 21:04 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
another (325.06 KB, patch)
2015-01-21 21:20 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
another (370.37 KB, patch)
2015-01-22 10:40 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
another (372.35 KB, patch)
2015-01-22 10:58 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
another (374.22 KB, patch)
2015-01-22 11:13 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
another (374.21 KB, patch)
2015-01-22 11:30 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
another (376.39 KB, patch)
2015-01-22 13:10 PST, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-01-15 07:34:11 PST
That's what it represents.
Comment 1 Antti Koivisto 2015-01-15 10:55:31 PST
Created attachment 244701 [details]
patch
Comment 2 Antti Koivisto 2015-01-15 11:14:29 PST
Created attachment 244703 [details]
patch
Comment 3 WebKit Commit Bot 2015-01-15 11:16:21 PST
Attachment 244703 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:49:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:142:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:256:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:336:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:337:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:337:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:338:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:338:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:339:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontIOS.mm:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontIOS.mm:54:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Font.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/Font.h:143:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:235:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:236:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:240:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:258:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:139:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:193:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:253:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontCascadeComplexTextMac.cpp:85:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontCascadeMac.mm:209:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 22 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Adler 2015-01-20 09:29:23 PST
Comment on attachment 244703 [details]
patch

I approve of the idea, but since EWS is all red, seems like you should upload a rebased one.
Comment 5 Antti Koivisto 2015-01-21 16:08:21 PST
Created attachment 245097 [details]
patch
Comment 6 WebKit Commit Bot 2015-01-21 16:10:53 PST
Attachment 245097 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Font.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/Font.h:143:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:235:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:236:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:240:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:258:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:139:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:193:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:253:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 9 in 82 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Antti Koivisto 2015-01-21 21:04:56 PST
Created attachment 245118 [details]
another
Comment 8 WebKit Commit Bot 2015-01-21 21:07:54 PST
Attachment 245118 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Font.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/Font.h:143:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:235:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:236:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:240:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:258:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:139:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:193:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:253:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 9 in 88 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Antti Koivisto 2015-01-21 21:20:12 PST
Created attachment 245119 [details]
another
Comment 10 Antti Koivisto 2015-01-22 10:40:54 PST
Created attachment 245147 [details]
another
Comment 11 WebKit Commit Bot 2015-01-22 10:42:27 PST
Attachment 245147 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/win/UniscribeController.h:59:  The parameter name "item" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6 in 118 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Antti Koivisto 2015-01-22 10:58:19 PST
Created attachment 245148 [details]
another
Comment 13 WebKit Commit Bot 2015-01-22 11:02:09 PST
Attachment 245148 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 119 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Antti Koivisto 2015-01-22 11:13:57 PST
Created attachment 245149 [details]
another
Comment 15 WebKit Commit Bot 2015-01-22 11:17:54 PST
Attachment 245149 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 119 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Antti Koivisto 2015-01-22 11:30:39 PST
Created attachment 245151 [details]
another
Comment 17 WebKit Commit Bot 2015-01-22 11:33:40 PST
Attachment 245151 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 119 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 Antti Koivisto 2015-01-22 13:10:00 PST
Created attachment 245156 [details]
another
Comment 19 WebKit Commit Bot 2015-01-22 13:12:38 PST
Attachment 245156 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 119 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 20 Antti Koivisto 2015-01-22 13:57:47 PST
https://trac.webkit.org/r178940