Bug 140442 - Rename Font to FontCascade
Summary: Rename Font to FontCascade
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 135290
  Show dependency tree / graph
 
Reported: 2015-01-14 08:11 PST by Antti Koivisto
Modified: 2015-01-15 12:44 PST (History)
7 users (show)

See Also:

Attachments
patch (383.41 KB, patch)
2015-01-14 08:15 PST, Antti Koivisto 		darin: review+
Details | Formatted Diff | Diff
for bots 2 (391.00 KB, patch)
2015-01-14 15:37 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (392.38 KB, patch)
2015-01-14 15:46 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (390.62 KB, patch)
2015-01-15 02:21 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (391.33 KB, patch)
2015-01-15 02:53 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (405.68 KB, patch)
2015-01-15 03:31 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (408.99 KB, patch)
2015-01-15 04:03 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (411.76 KB, patch)
2015-01-15 05:39 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (412.92 KB, patch)
2015-01-15 05:50 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (414.35 KB, patch)
2015-01-15 06:03 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-01-14 08:11:45 PST 
We can then rename SimpleFontData to Font. This will match better the usual definition of "font".
Comment 1 Antti Koivisto 2015-01-14 08:15:44 PST 
Created attachment 244604 [details]
patch
Comment 2 WebKit Commit Bot 2015-01-14 08:17:37 PST 
Attachment 244604 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/FontCascade.h:272:  The parameter name "c" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:737:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:738:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:817:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:943:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 139 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2015-01-14 08:55:51 PST 
Comment on attachment 244604 [details]
patch

Need to update CMakeList.txt.

Also, I agree with the style bot.
Comment 4 Antti Koivisto 2015-01-14 15:37:10 PST 
Created attachment 244653 [details]
for bots 2
Comment 5 Myles C. Maxfield 2015-01-14 15:42:27 PST 
Oh my lord
Comment 6 Antti Koivisto 2015-01-14 15:46:04 PST 
Created attachment 244655 [details]
another
Comment 7 Antti Koivisto 2015-01-15 02:21:05 PST 
Created attachment 244684 [details]
another
Comment 8 Antti Koivisto 2015-01-15 02:53:15 PST 
Created attachment 244685 [details]
another
Comment 9 Antti Koivisto 2015-01-15 03:31:23 PST 
Created attachment 244686 [details]
another
Comment 10 WebKit Commit Bot 2015-01-15 03:43:55 PST 
Attachment 244686 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/win/UniscribeController.h:30:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 1 in 149 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Antti Koivisto 2015-01-15 04:03:01 PST 
Created attachment 244687 [details]
another
Comment 12 WebKit Commit Bot 2015-01-15 04:05:44 PST 
Attachment 244687 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/win/UniscribeController.h:30:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 1 in 151 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Antti Koivisto 2015-01-15 05:39:57 PST 
Created attachment 244688 [details]
another
Comment 14 Antti Koivisto 2015-01-15 05:50:02 PST 
Created attachment 244689 [details]
patch
Comment 15 Antti Koivisto 2015-01-15 06:03:11 PST 
Created attachment 244690 [details]
another
Comment 16 Antti Koivisto 2015-01-15 06:21:43 PST 
https://trac.webkit.org/r178510
Comment 17 Csaba Osztrogonác 2015-01-15 09:19:40 PST 
(In reply to comment #16)
> https://trac.webkit.org/r178510

It broke the Apple Windows build.
Comment 18 Antti Koivisto 2015-01-15 11:44:36 PST 
https://trac.webkit.org/r178520 should help some