Bug 131756 – Fix CodeGenerator.pm to only write files if the generated content has changed

• Status: RESOLVED
• Resolution: LATER
• Component: Tools / Tests

[Bem Jones-Bey]

Fix CodeGenerator.pm to only write files if the generated content has changed

[Bem Jones-Bey]

Created attachment 229475 [details]
Patch

[Sam Weinig]

Comment on attachment 229475 [details]
Patch

Sweet!

[WebKit Commit Bot]

Comment on attachment 229475 [details]
Patch

Clearing flags on attachment: 229475

Committed r167384: <http://trac.webkit.org/changeset/167384>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time.

Am I missing something?

[Bem Jones-Bey]

(In reply to comment #5)
> I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time.
> 
> Am I missing something?

You're right, that is a problem with this change. I believe I can fix that problem, however. I'll work on a fix for that today.

[Bem Jones-Bey]

(In reply to comment #6)
> (In reply to comment #5)
> > I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time.
> > 
> > Am I missing something?
> 
> You're right, that is a problem with this change. I believe I can fix that problem, however. I'll work on a fix for that today.

I have a fix for the Mac build in Bug 131820.

[Bem Jones-Bey]

Reverted r167384 for reason:

Sounds like this isn't the right fix, and causes generation to run far too often.

Committed r167474: <http://trac.webkit.org/changeset/167474>

[Bem Jones-Bey]

I have no brilliant ideas on fixing this in the near term, so closing for now.

[Fujii Hironori]

generate-bindings-all.pl solves the original problem in a different approach.

* Bug 161433 – [CMake] CMake does not support the dep files for implicit dependency
* Bug 164054 – generate-bindings-all.pl should recompile supplemented IDL if its supplemental IDL are added or removed
* Bug 164121 – [CMake] Changing enabled features should trigger recompiling all IDL