RESOLVED FIXED 164121
[CMake] Changing enabled features should trigger recompiling all IDL 
https://bugs.webkit.org/show_bug.cgi?id=164121
Summary [CMake] Changing enabled features should trigger recompiling all IDL
Fujii Hironori
Reported 2016-10-28 04:27:44 PDT
Changing enabled features should trigger recompiling all IDL because some of them use #if. generate-bindings-all.pl was introduced in <http://trac.webkit.org/changeset/207617>. Before this change, updating supplemental_dependency.tmp triggered regenerating all bindings. Changing enabled features usually involves adding or removing IDL files. As the result, all IDL would be recompiled. But, after the change, updating supplemental_dependency.tmp does trigger regenerating all bindings. So, we need to explicitly trigger recompiling all IDL by changing enabled features.
Attachments
Patch (2.08 KB, patch)
2016-10-28 04:41 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2016-10-28 04:41:04 PDT
Created attachment 293143 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-28 05:27:27 PDT
Comment on attachment 293143 [details] Patch Clearing flags on attachment: 293143 Committed r208044: <http://trac.webkit.org/changeset/208044>
WebKit Commit Bot
Comment 3 2016-10-28 05:27:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.