Bug 164121 - [CMake] Changing enabled features should trigger recompiling all IDL
Summary: [CMake] Changing enabled features should trigger recompiling all IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-28 04:27 PDT by Fujii Hironori
Modified: 2016-10-28 05:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2016-10-28 04:41 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2016-10-28 04:27:44 PDT 
Changing enabled features should trigger recompiling all IDL
because some of them use #if.

generate-bindings-all.pl was introduced in
<http://trac.webkit.org/changeset/207617>.  Before this change,
updating supplemental_dependency.tmp triggered regenerating all
bindings. Changing enabled features usually involves adding or
removing IDL files. As the result, all IDL would be recompiled.
But, after the change, updating supplemental_dependency.tmp does
trigger regenerating all bindings. So, we need to explicitly
trigger recompiling all IDL by changing enabled features.
Comment 1 Fujii Hironori 2016-10-28 04:41:04 PDT 
Created attachment 293143 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-28 05:27:27 PDT 
Comment on attachment 293143 [details]
Patch

Clearing flags on attachment: 293143

Committed r208044: <http://trac.webkit.org/changeset/208044>
Comment 3 WebKit Commit Bot 2016-10-28 05:27:31 PDT 
All reviewed patches have been landed.  Closing bug.