WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
131820
Fix Mac build so that bindings generators are not run every build
https://bugs.webkit.org/show_bug.cgi?id=131820
Summary
Fix Mac build so that bindings generators are not run every build
Bem Jones-Bey
Reported
2014-04-17 15:01:32 PDT
Fix Mac build so that bindings generators are not run every build
Attachments
Patch
(3.99 KB, patch)
2014-04-17 15:05 PDT
,
Bem Jones-Bey
no flags
Details
Formatted Diff
Diff
Patch
(4.69 KB, patch)
2014-04-17 15:35 PDT
,
Bem Jones-Bey
simon.fraser
: review-
simon.fraser
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1
2014-04-17 15:05:32 PDT
Created
attachment 229580
[details]
Patch
Bem Jones-Bey
Comment 2
2014-04-17 15:07:22 PDT
Once this has been reviewed, I will file bugs for the other ports, so their maintainers can do something similar.
Bem Jones-Bey
Comment 3
2014-04-17 15:35:07 PDT
Created
attachment 229585
[details]
Patch Fix a couple things I missed on the first version
Simon Fraser (smfr)
Comment 4
2014-04-17 16:16:59 PDT
I think it would be better to always generate the output file if the IDL file timestamp is newer (just like other dependencies).
Bem Jones-Bey
Comment 5
2014-04-17 16:39:32 PDT
(In reply to
comment #4
)
> I think it would be better to always generate the output file if the IDL file timestamp is newer (just like other dependencies).
That pretty much means reverting the patch for
Bug 131756
. I'm OK with that if that isn't the right fix for the problem. The original problem was that it happens that the IDL file gets updated but it hasn't actually changed in a way that causes the generated files to be different, but since they got touched by the generators, they ended up getting recompiled anyways.
Simon Fraser (smfr)
Comment 6
2014-04-17 17:38:57 PDT
Comment on
attachment 229585
[details]
Patch Let's roll out the previous patch, and if we think we can touch generated files less but keep them more recent than the IDL files, do that.
Bem Jones-Bey
Comment 7
2014-04-17 18:06:42 PDT
Rolled out the fix for
Bug 131756
. So this isn't needed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug