Bug 131820 - Fix Mac build so that bindings generators are not run every build
Summary: Fix Mac build so that bindings generators are not run every build
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-17 15:01 PDT by Bem Jones-Bey
Modified: 2014-04-17 18:06 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.99 KB, patch)
2014-04-17 15:05 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff
Patch (4.69 KB, patch)
2014-04-17 15:35 PDT, Bem Jones-Bey
simon.fraser: review-
simon.fraser: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2014-04-17 15:01:32 PDT
Fix Mac build so that bindings generators are not run every build
Comment 1 Bem Jones-Bey 2014-04-17 15:05:32 PDT
Created attachment 229580 [details]
Patch
Comment 2 Bem Jones-Bey 2014-04-17 15:07:22 PDT
Once this has been reviewed, I will file bugs for the other ports, so their maintainers can do something similar.
Comment 3 Bem Jones-Bey 2014-04-17 15:35:07 PDT
Created attachment 229585 [details]
Patch

Fix a couple things I missed on the first version
Comment 4 Simon Fraser (smfr) 2014-04-17 16:16:59 PDT
I think it would be better to always generate the output file if the IDL file timestamp is newer (just like other dependencies).
Comment 5 Bem Jones-Bey 2014-04-17 16:39:32 PDT
(In reply to comment #4)
> I think it would be better to always generate the output file if the IDL file timestamp is newer (just like other dependencies).

That pretty much means reverting the patch for Bug 131756. I'm OK with that if that isn't the right fix for the problem. The original problem was that it happens that the IDL file gets updated but it hasn't actually changed in a way that causes the generated files to be different, but since they got touched by the generators, they ended up getting recompiled anyways.
Comment 6 Simon Fraser (smfr) 2014-04-17 17:38:57 PDT
Comment on attachment 229585 [details]
Patch

Let's roll out the previous patch, and if we think we can touch generated files less but keep them more recent than the IDL files, do that.
Comment 7 Bem Jones-Bey 2014-04-17 18:06:42 PDT
Rolled out the fix for Bug 131756. So this isn't needed.