Patch forthcoming.
Created attachment 224149 [details] work in progress
Created attachment 224162 [details] work in progress
Created attachment 224168 [details] it ran things
Comment on attachment 224168 [details] it ran things Calling it "the patch" might be overconfident.
Attachment 224168 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:49: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:51: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 9 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 224283 [details] the patch Note that this has a strong dependency on https://bugs.webkit.org/show_bug.cgi?id=128864. It'll probably crash every test on EWS.
Attachment 224283 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:49: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:51: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:131: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 10 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 224283 [details] the patch Attachment 224283 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5530863127232512 New failing tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html editing/inserting/insert-composition-whitespace.html css3/compositing/background-blend-mode-property-parsing.html cssom/cssvalue-comparison.html compositing/overflow/automatically-opt-into-composited-scrolling.html accessibility/canvas-fallback-content-2.html css3/flexbox/box-sizing.html accessibility/canvas-fallback-content.html css3/filters/filter-property-parsing.html editing/execCommand/enabling-and-selection.html css3/flexbox/align-absolute-child.html css3/compositing/blend-mode-property-parsing.html editing/execCommand/enabling-and-selection-2.html css3/filters/filter-property-computed-style.html css3/filters/offscreen-filters-memory-usage.html animations/animation-direction-reverse-hardware.html canvas/philip/tests/2d.imageData.put.unchanged.html editing/pasteboard/4076267-3.html css3/filters/filter-property-parsing-invalid.html css3/flexbox/auto-height-dynamic.html http/tests/loading/slow-parsing-subframe.html http/tests/css/shared-stylesheet-mutation-preconstruct.html css3/flexbox/columns-auto-size.html css3/unicode-bidi-isolate-basic.html css3/zoom-coords.xhtml http/tests/css/shared-stylesheet-mutation.html http/tests/misc/acid3.html editing/deleting/5206311-2.html editing/deleting/delete-4038408-fix.html css3/flexbox/box-sizing-min-max-sizes.html
Created attachment 224291 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 224305 [details] the patch
Attachment 224305 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:92: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 10 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #11) > Attachment 224305 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] No. > ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:92: Should have a space between // and comment [whitespace/comments] [4] Ooops, fixed. > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] Fixed. > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Fixed. > Total errors found: 10 in 49 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 224306 [details] the patch
Attachment 224306 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 4 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 224310 [details] the patch
Attachment 224310 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGCommon.h:31: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in http://trac.webkit.org/changeset/164207
*** Bug 66314 has been marked as a duplicate of this bug. ***