Bug 128796 - Kill some of the last vestiges of the C++ interpreter's PICs
Summary: Kill some of the last vestiges of the C++ interpreter's PICs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 128795
  Show dependency tree / graph
 
Reported: 2014-02-13 20:31 PST by Filip Pizlo
Modified: 2014-02-13 21:35 PST (History)
10 users (show)

See Also:

Attachments
the patch (24.25 KB, patch)
2014-02-13 20:31 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
the patch (25.36 KB, patch)
2014-02-13 20:57 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-13 20:31:03 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-13 20:31:47 PST 
Created attachment 224154 [details]
the patch
Comment 2 WebKit Commit Bot 2014-02-13 20:34:04 PST 
Attachment 224154 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _stubRoutine is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _base is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _chain is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _isDirect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _count is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2014-02-13 20:57:06 PST 
Created attachment 224157 [details]
the patch

Still R=michael, trying to fix the build.
Comment 4 WebKit Commit Bot 2014-02-13 20:58:50 PST 
Attachment 224157 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _stubRoutine is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _base is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _chain is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _isDirect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _count is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2014-02-13 21:35:25 PST 
Landed in http://trac.webkit.org/changeset/164092