RESOLVED FIXED 126236
Web Inspector: Clean up dead/useless code 
https://bugs.webkit.org/show_bug.cgi?id=126236
Summary Web Inspector: Clean up dead/useless code
Seokju Kwon
Reported 2013-12-25 15:43:21 PST
Master bug. There are so many dead codes in WebInspectorUI.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-12-25 15:43:31 PST
<rdar://problem/15725242>
Seokju Kwon
Comment 2 2014-01-07 21:50:47 PST
I will try to get rid of unused overriding protocols. Any opinions welcome on this. And I will file bugs if there is no objection. -Page.setGeolocationOverride -Page.clearGeolocationOverride -Page.canOverrideGeolocation -Page.setDeviceOrientationOverride -Page.clearDeviceOrientationOverride -Page.canOverrideGeolocation -Network.setUserAgentOverride
Timothy Hatcher
Comment 3 2014-01-07 21:58:48 PST
(In reply to comment #2) > I will try to get rid of unused overriding protocols. > Any opinions welcome on this. And I will file bugs if there is no objection. > > -Page.setGeolocationOverride > -Page.clearGeolocationOverride > -Page.canOverrideGeolocation > -Page.setDeviceOrientationOverride > -Page.clearDeviceOrientationOverride > -Page.canOverrideGeolocation > -Network.setUserAgentOverride Those are all fine to remove.
Seokju Kwon
Comment 4 2014-01-10 00:52:59 PST
Another attempt to remove protocols. Please let me know what you think. Page.setShowPaintRects Page.canShowDebugBorders Page.setShowDebugBorders Page.canShowFPSCounter Page.setShowFPSCounter Page.canContinuouslyPaint PAge.setContinuousPaintingEnabled
Timothy Hatcher
Comment 5 2014-01-10 05:46:53 PST
(In reply to comment #4) > Another attempt to remove protocols. Please let me know what you think. > > Page.setShowPaintRects > Page.canShowDebugBorders > Page.setShowDebugBorders > Page.canShowFPSCounter > Page.setShowFPSCounter > Page.canContinuouslyPaint > PAge.setContinuousPaintingEnabled Lets keep setShowPaintRects.
Joseph Pecoraro
Comment 6 2016-12-14 10:34:11 PST
I am pretty sure these have all been deleted by now.
Blaze Burg
Comment 7 2016-12-14 11:42:11 PST
Thanks Joe!
Note You need to log in before you can comment on or make changes to this bug.