Bug 126607 – Web Inspector: Remove leftover 'device metrics' code

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Seokju Kwon]

Removes unused code related to 'device metrics'.

[Radar WebKit Bug Importer]

<rdar://problem/15768387>

[Seokju Kwon]

Created attachment 220571 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 220571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220571&action=review

r=me, one nit

> Source/WebCore/rendering/TextAutosizer.cpp:119
>      if (windowInfo.windowSize.isEmpty()) {
> -        bool includeScrollbars = !InspectorInstrumentation::shouldApplyScreenWidthOverride(&mainFrame);
> -        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(includeScrollbars ? ScrollableArea::IncludeScrollbars : ScrollableArea::ExcludeScrollbars);
> +        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(ScrollableArea::IncludeScrollbars);
>      }

Style: Remove the braces for this if now that it is s single statement.

[Seokju Kwon]

(In reply to comment #3)
> (From update of attachment 220571 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220571&action=review
> 
> r=me, one nit
> 
> > Source/WebCore/rendering/TextAutosizer.cpp:119
> >      if (windowInfo.windowSize.isEmpty()) {
> > -        bool includeScrollbars = !InspectorInstrumentation::shouldApplyScreenWidthOverride(&mainFrame);
> > -        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(includeScrollbars ? ScrollableArea::IncludeScrollbars : ScrollableArea::ExcludeScrollbars);
> > +        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(ScrollableArea::IncludeScrollbars);
> >      }
> 
> Style: Remove the braces for this if now that it is s single statement.

Thanks. I will fix it.

[Seokju Kwon]

Created attachment 220574 [details]
Patch

[Seokju Kwon]

Created attachment 220576 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 220576 [details]
Patch

Clearing flags on attachment: 220576

Committed r161477: <http://trac.webkit.org/changeset/161477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.