Bug 126607 - Web Inspector: Remove leftover 'device metrics' code
Summary: Web Inspector: Remove leftover 'device metrics' code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Seokju Kwon
URL:
Keywords: InRadar
Depends on:
Blocks: 126236
  Show dependency treegraph
 
Reported: 2014-01-07 17:05 PST by Seokju Kwon
Modified: 2014-01-07 18:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (29.81 KB, patch)
2014-01-07 17:17 PST, Seokju Kwon
no flags Details | Formatted Diff | Diff
Patch (29.93 KB, patch)
2014-01-07 17:37 PST, Seokju Kwon
no flags Details | Formatted Diff | Diff
Patch (29.93 KB, patch)
2014-01-07 17:42 PST, Seokju Kwon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2014-01-07 17:05:18 PST
Removes unused code related to 'device metrics'.
Comment 1 Radar WebKit Bug Importer 2014-01-07 17:06:17 PST
<rdar://problem/15768387>
Comment 2 Seokju Kwon 2014-01-07 17:17:43 PST
Created attachment 220571 [details]
Patch
Comment 3 Joseph Pecoraro 2014-01-07 17:33:33 PST
Comment on attachment 220571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220571&action=review

r=me, one nit

> Source/WebCore/rendering/TextAutosizer.cpp:119
>      if (windowInfo.windowSize.isEmpty()) {
> -        bool includeScrollbars = !InspectorInstrumentation::shouldApplyScreenWidthOverride(&mainFrame);
> -        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(includeScrollbars ? ScrollableArea::IncludeScrollbars : ScrollableArea::ExcludeScrollbars);
> +        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(ScrollableArea::IncludeScrollbars);
>      }

Style: Remove the braces for this if now that it is s single statement.
Comment 4 Seokju Kwon 2014-01-07 17:37:12 PST
(In reply to comment #3)
> (From update of attachment 220571 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220571&action=review
> 
> r=me, one nit
> 
> > Source/WebCore/rendering/TextAutosizer.cpp:119
> >      if (windowInfo.windowSize.isEmpty()) {
> > -        bool includeScrollbars = !InspectorInstrumentation::shouldApplyScreenWidthOverride(&mainFrame);
> > -        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(includeScrollbars ? ScrollableArea::IncludeScrollbars : ScrollableArea::ExcludeScrollbars);
> > +        windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(ScrollableArea::IncludeScrollbars);
> >      }
> 
> Style: Remove the braces for this if now that it is s single statement.

Thanks. I will fix it.
Comment 5 Seokju Kwon 2014-01-07 17:37:24 PST
Created attachment 220574 [details]
Patch
Comment 6 Seokju Kwon 2014-01-07 17:42:06 PST
Created attachment 220576 [details]
Patch
Comment 7 WebKit Commit Bot 2014-01-07 18:16:50 PST
Comment on attachment 220576 [details]
Patch

Clearing flags on attachment: 220576

Committed r161477: <http://trac.webkit.org/changeset/161477>
Comment 8 WebKit Commit Bot 2014-01-07 18:16:52 PST
All reviewed patches have been landed.  Closing bug.