Remove unused overriding protocols. -Page.setGeolocationOverride -Page.clearGeolocationOverride -Page.canOverrideGeolocation -Page.setDeviceOrientationOverride -Page.clearDeviceOrientationOverride -Page.canOverrideGeolocation -Network.setUserAgentOverride
<rdar://problem/15770823>
Created attachment 220611 [details] Patch
Comment on attachment 220611 [details] Patch Attachment 220611 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5122645074903040
Comment on attachment 220611 [details] Patch Attachment 220611 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5909092778377216
Comment on attachment 220611 [details] Patch Attachment 220611 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/4537931716886528
Comment on attachment 220611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220611&action=review Other than the build issue this looks good to me. > Source/WebCore/dom/DeviceOrientationController.cpp:-60 > - orientation = InspectorInstrumentation::overrideDeviceOrientation(m_page, orientation); Looks like there is more code that can be removed here, since m_page is no longer used! (ews-mac build error): In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/dom/DeviceOrientationController.cpp:28: /Volumes/Data/EWS/WebKit/Source/WebCore/dom/DeviceOrientationController.h:66:11: error: private field 'm_page' is not used [-Werror,-Wunused-private-field] Page* m_page; ^ 1 error generated.
Created attachment 220682 [details] Patch
Comment on attachment 220682 [details] Patch Hum.. Build bots are not working. :( @Joepeck I have removed unused private field. Please take another look at this when build bots are happy.
Comment on attachment 220682 [details] Patch Attachment 220682 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6567514083426304
Comment on attachment 220682 [details] Patch Attachment 220682 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6713594376880128
Created attachment 220689 [details] Patch
Comment on attachment 220689 [details] Patch Clearing flags on attachment: 220689 Committed r161556: <http://trac.webkit.org/changeset/161556>
All reviewed patches have been landed. Closing bug.