Bug 126377 - Web Inspector: Frontend has no support for memory
Summary: Web Inspector: Frontend has no support for memory
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Seokju Kwon
Keywords: InRadar
Depends on:
Blocks: 126236
  Show dependency treegraph
Reported: 2014-01-02 00:24 PST by Seokju Kwon
Modified: 2015-08-27 16:07 PDT (History)
7 users (show)

See Also:

Patch (29.59 KB, patch)
2014-01-02 00:28 PST, Seokju Kwon
joepeck: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2014-01-02 00:24:10 PST
Remove protocol and agent code of memory.
Comment 1 Radar WebKit Bug Importer 2014-01-02 00:24:51 PST
Comment 2 Seokju Kwon 2014-01-02 00:28:57 PST
Created attachment 220211 [details]
Comment 3 Joseph Pecoraro 2014-01-06 11:08:01 PST
Comment on attachment 220211 [details]

Although the frontend does not use it, if we did would getDOMCounters be correct? It looks like it would be. Maybe instead of removing this domain we could make use of that data.

That said, "MemoryBlock" doesn't look like it is used at all.

Memory instrumentation is certainly something we will want to add to the inspection. We will probably reimplement it anyways, and if we do go through and remove this implementation here we can dig up this old code.

For starters, r- this code now anyways because if we did remove it there is even more code that we should remove (the counter tracking itself!):

43:    class ThreadLocalInspectorCounters;
70:        ThreadLocalInspectorCounters& inspectorCounters() { return *m_inspectorCounters; }
91:        OwnPtr<ThreadLocalInspectorCounters> m_inspectorCounters;

61:    return threadGlobalData().inspectorCounters();

55:    ThreadLocalInspectorCounters::current().incrementCounter(ThreadLocalInspectorCounters::JSEventListenerCounter);
62:    ThreadLocalInspectorCounters::current().decrementCounter(ThreadLocalInspectorCounters::JSEventListenerCounter);
Comment 4 Timothy Hatcher 2014-01-08 13:40:17 PST
Comment on attachment 220211 [details]

Yeah, lets leave getDOMCounters. Maybe moving it to the Page domain would be better?
Comment 5 Timothy Hatcher 2015-08-27 16:07:42 PDT
Was removed in http://trac.webkit.org/changeset/164637.