Bug 126377 – Web Inspector: Frontend has no support for memory

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Seokju Kwon]

Remove protocol and agent code of memory.

[Radar WebKit Bug Importer]

<rdar://problem/15737029>

[Seokju Kwon]

Created attachment 220211 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 220211 [details]
Patch

Although the frontend does not use it, if we did would getDOMCounters be correct? It looks like it would be. Maybe instead of removing this domain we could make use of that data.

That said, "MemoryBlock" doesn't look like it is used at all.

Memory instrumentation is certainly something we will want to add to the inspection. We will probably reimplement it anyways, and if we do go through and remove this implementation here we can dig up this old code.

For starters, r- this code now anyways because if we did remove it there is even more code that we should remove (the counter tracking itself!):

platform/ThreadGlobalData.h
43:    class ThreadLocalInspectorCounters;
70:        ThreadLocalInspectorCounters& inspectorCounters() { return *m_inspectorCounters; }
91:        OwnPtr<ThreadLocalInspectorCounters> m_inspectorCounters;

inspector/InspectorCounters.cpp
61:    return threadGlobalData().inspectorCounters();

bindings/js/JSEventListener.cpp
55:    ThreadLocalInspectorCounters::current().incrementCounter(ThreadLocalInspectorCounters::JSEventListenerCounter);
62:    ThreadLocalInspectorCounters::current().decrementCounter(ThreadLocalInspectorCounters::JSEventListenerCounter);

[Timothy Hatcher]

Comment on attachment 220211 [details]
Patch

Yeah, lets leave getDOMCounters. Maybe moving it to the Page domain would be better?

[Timothy Hatcher]

Was removed in http://trac.webkit.org/changeset/164637.