Bug 123027 - Make IDBDatabaseBackendLevelDB.cpp be cross platform
Summary: Make IDBDatabaseBackendLevelDB.cpp be cross platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 123028 123039 123074 123105 123124 123138 123174
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-18 10:29 PDT by Brady Eidson
Modified: 2013-10-23 11:12 PDT (History)
8 users (show)

See Also:

Attachments
Patch v1 (107.39 KB, patch)
2013-10-22 22:01 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 - More style, more building. (106.83 KB, patch)
2013-10-22 22:24 PDT, Brady Eidson 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-10-18 10:29:02 PDT 
Make IDBDatabaseBackendLevelDB.cpp be cross platform

This class has a lot of the main cross platform IDB logic in it, but it is also closely tied to LevelDB classes.

There's a few refactoring steps available that will let us make this cross platform.  I will file them as blocking bugs as they come up.
Comment 1 Brady Eidson 2013-10-22 22:01:09 PDT 
Created attachment 214927 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-10-22 22:03:25 PDT 
Attachment 214927 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBLevelDBCoding.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h']" exit_code: 1
Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h:58:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2013-10-22 22:24:31 PDT 
Created attachment 214929 [details]
Patch v2 - More style, more building.
Comment 4 Brady Eidson 2013-10-23 11:12:48 PDT 
http://trac.webkit.org/changeset/157869