Bug 123174 - Get rid of IDBObjectStoreBackendLevelDB
Summary: Get rid of IDBObjectStoreBackendLevelDB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 123027
  Show dependency tree / graph
 
Reported: 2013-10-22 14:22 PDT by Brady Eidson
Modified: 2013-10-22 20:47 PDT (History)
10 users (show)

See Also:

Attachments
Patch v1 (51.92 KB, patch)
2013-10-22 14:56 PDT, Brady Eidson 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch v2 - EWS just for sanity (53.85 KB, patch)
2013-10-22 19:29 PDT, Brady Eidson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-10-22 14:22:12 PDT 
Get rid of IDBObjectStoreBackendLevelDB

This stuff can be merged into IDBBackingStoreInterface and a new IDBIndexWriter class.

Part of the push towards https://bugs.webkit.org/show_bug.cgi?id=123027
Comment 1 Brady Eidson 2013-10-22 14:56:21 PDT 
Created attachment 214888 [details]
Patch v1
Comment 2 Brady Eidson 2013-10-22 15:23:05 PDT 
Mac ews will fail - Once again I forgot to include WK2 changes!  Updating shortly.
Comment 3 Build Bot 2013-10-22 15:26:07 PDT 
Comment on attachment 214888 [details]
Patch v1 

Attachment 214888 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/9408004
Comment 4 Tim Horton 2013-10-22 15:27:43 PDT 
Comment on attachment 214888 [details]
Patch v1 

View in context: https://bugs.webkit.org/attachment.cgi?id=214888&action=review

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:1350
> +

extra space
Comment 5 Build Bot 2013-10-22 15:28:28 PDT 
Comment on attachment 214888 [details]
Patch v1 

Attachment 214888 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/9358007
Comment 6 Build Bot 2013-10-22 15:42:39 PDT 
Comment on attachment 214888 [details]
Patch v1 

Attachment 214888 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4428012
Comment 7 Brady Eidson 2013-10-22 19:29:30 PDT 
Created attachment 214919 [details]
Patch v2 - EWS just for sanity
Comment 8 Brady Eidson 2013-10-22 19:45:16 PDT 
"Unable to build without patch"

Great.  This is a useless exercise.
Comment 9 Build Bot 2013-10-22 20:12:24 PDT 
Comment on attachment 214919 [details]
Patch v2 - EWS just for sanity

Attachment 214919 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/7828065
Comment 10 Brady Eidson 2013-10-22 20:22:05 PDT 
http://trac.webkit.org/changeset/157844
Comment 12 Brady Eidson 2013-10-22 20:41:53 PDT 
Why is any of this affecting the windows build?  Indexed DB is not enabled on Windows.(In reply to comment #11)
> This patch broke the Windows build:
> http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/71846/steps/compile-webkit/logs/stdio
> 
> Landed gardening fix in r157845: <http://trac.webkit.org/r157845>.

Why is any of this affecting the windows build?  Indexed DB is not enabled on Windows.  (Or, at least, not supposed to be.)
Comment 13 Mark Lam 2013-10-22 20:43:38 PDT 
(In reply to comment #12)
> Why is any of this affecting the windows build?  Indexed DB is not enabled on Windows.  (Or, at least, not supposed to be.)

The deleted file was still included the VC project and the build was failing to find it.  I simply remove the reference to it since the file is now deleted.
Comment 14 Brady Eidson 2013-10-22 20:47:38 PDT 
(In reply to comment #13)
> (In reply to comment #12)
> > Why is any of this affecting the windows build?  Indexed DB is not enabled on Windows.  (Or, at least, not supposed to be.)
> 
> The deleted file was still included the VC project and the build was failing to find it.  I simply remove the reference to it since the file is now deleted.

I see, yikes.  The entire Modules/indexeddb/leveldb directory can be removed from the vcproj if this ever comes up again.