Bug 123105 – Transition most use of IDBBackingStoreLevelDB to IDBBackingStoreInterface

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Transition most use of IDBBackingStoreLevelDB to IDBBackingStoreInterface

This gets us even closer to the goal in https://bugs.webkit.org/show_bug.cgi?id=123027 - Make IDBDatabaseBackendLevelDB.cpp be cross platform

[Brady Eidson]

Created attachment 214752 [details]
Patch v1

[WebKit Commit Bot]

Attachment 214752 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h', u'Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h']" exit_code: 1
Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:95:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:99:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:109:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:111:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:48:  The parameter name "backingStore" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:96:  The parameter name "backingStore" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 214752 [details]
Patch v1 

Attachment 214752 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/8828075

[Brady Eidson]

(In reply to comment #2)
> Attachment 214752 [details] did not pass style-queue:
> Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:95:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:99:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:109:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h:111:  The parameter name "transaction" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:48:  The parameter name "backingStore" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:96:  The parameter name "backingStore" adds no information, so it should be removed.  [readability/parameter_name] [5]

All fixed locally.

[EFL EWS Bot]

Comment on attachment 214752 [details]
Patch v1 

Attachment 214752 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/8788078

[Tim Horton]

View in context: https://bugs.webkit.org/attachment.cgi?id=214752&action=review

> Source/WebCore/ChangeLog:7
> +

Extra space.

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:1979
> +    m_transaction = LevelDBTransaction::create(reinterpret_cast<IDBBackingStoreLevelDB*>(m_backingStore)->m_db.get());

:|

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:80
> +    class RecordIdentifier : public IDBBackingStoreInterface::RecordIdentifier {

Is this class not FINAL in its entirety? You could do that here instead of repeatedly below.

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:120
> +    class Cursor : public IDBBackingStoreInterface::Cursor {

Ditto.

[Build Bot]

Comment on attachment 214752 [details]
Patch v1 

Attachment 214752 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/8868076

[Brady Eidson]

The linux builds apparently can't handle the sequence of "WARN_UNUSED_RETURN OVERRIDE FINAL"
I've tried changing that to "OVERRIDE FINAL WARN_UNUSED_RETURN" and will upload a new patch.

[Build Bot]

Comment on attachment 214752 [details]
Patch v1 

Attachment 214752 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/8888106

[kov's GTK+ EWS bot]

Comment on attachment 214752 [details]
Patch v1 

Attachment 214752 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/8808108

[Brady Eidson]

Created attachment 214761 [details]
Patch v2 - Fix WK2 build, and hopefully make the linux compilers happy.

[EFL EWS Bot]

Comment on attachment 214761 [details]
Patch v2 - Fix WK2 build, and hopefully make the linux compilers happy.

Attachment 214761 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/8778104

[Brady Eidson]

Yup, one more non-implemented method for the vanilla WebCore levelDB build.  Fixing.

[Brady Eidson]

Created attachment 214762 [details]
Patch v3

[WebKit Commit Bot]

Attachment 214762 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h', u'Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/config.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h']" exit_code: 1
Source/WebCore/config.h:34:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 214762 [details]
Patch v3

Attachment 214762 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/4998145

[Brady Eidson]

(In reply to comment #15)
> Attachment 214762 [details] did not pass style-queue:
> 
> Source/WebCore/config.h:34:  Should have a space between // and comment  [whitespace/comments] [4]
Didn't mean to include that at all, removed locally.

[Brady Eidson]

Created attachment 214766 [details]
Patch v4 - Trying this again...

[Anders Carlsson]

Comment on attachment 214766 [details]
Patch v4 - Trying this again...

View in context: https://bugs.webkit.org/attachment.cgi?id=214766&action=review

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:70
> +    virtual bool getIDBDatabaseMetaData(const String& name, IDBDatabaseMetadata*, bool& success) OVERRIDE FINAL WARN_UNUSED_RETURN;

Instead of making all these FINAL you can just make the class itself final.

[Brady Eidson]

http://trac.webkit.org/changeset/157730