Bug 122318 - FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and stack layout
Summary: FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 113647 116189 122487 122739 123219
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2013-10-03 22:00 PDT by Filip Pizlo
Modified: 2013-11-03 10:22 PST (History)
8 users (show)

See Also:

Attachments
LLVM trunk patch to support new webkit intrinsics. (32.47 KB, patch)
2013-10-04 11:12 PDT, Andrew Trick 		no flags Details | Formatted Diff | Diff
rebased LLVM patch (48.73 KB, patch)
2013-10-07 11:39 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (33.22 KB, patch)
2013-11-02 20:18 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (33.99 KB, patch)
2013-11-02 20:54 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-03 22:00:28 PDT 
Patch and further description forthcoming.
Comment 1 Andrew Trick 2013-10-04 11:12:28 PDT 
Created attachment 213378 [details]
LLVM trunk patch to support new webkit intrinsics.
Comment 2 Filip Pizlo 2013-10-07 11:39:40 PDT 
Created attachment 213605 [details]
rebased LLVM patch

Just rebasing.
Comment 3 Mark Rowe (bdash) 2013-10-09 02:37:00 PDT 
Probably worth using the correct spellings of JavaScript and WebKit in the comments within the LLVM patch. You've used "Java Script", "javascript" and "webkit" in various places.
Comment 4 Filip Pizlo 2013-10-23 13:46:53 PDT 
OK, it looks like we have GetById IC's and OSR exits working with stackmap/patchpoint.  So, as far as I can tell, those intrinsics Work As Advertised.  So lets get 'em landed in LLVM trunk!
Comment 5 Filip Pizlo 2013-11-02 20:18:03 PDT 
Created attachment 215844 [details]
the patch
Comment 6 Filip Pizlo 2013-11-02 20:54:41 PDT 
Created attachment 215845 [details]
the patch
Comment 7 Geoffrey Garen 2013-11-03 10:18:19 PST 
Comment on attachment 215845 [details]
the patch

r=me
Comment 8 Filip Pizlo 2013-11-03 10:22:56 PST 
Landed in http://trac.webkit.org/changeset/158535