Bug 123219 - Put all uses of LLVM intrinsics behind a single Option
Summary: Put all uses of LLVM intrinsics behind a single Option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 122318
  Show dependency treegraph
 
Reported: 2013-10-23 13:49 PDT by Filip Pizlo
Modified: 2013-10-23 13:56 PDT (History)
9 users (show)

See Also:


Attachments
the patch (4.65 KB, patch)
2013-10-23 13:50 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-23 13:49:26 PDT
It turns out that the code can't handle turning on IC-with-patchpoint while leaving OSR-with-stackmap off.  And I don't think it would be worthwhile to fix that bug since in the long run, we just want to always use the intrinsics.

So, we should unify these different options into one.
Comment 1 Filip Pizlo 2013-10-23 13:50:07 PDT
Created attachment 214992 [details]
the patch
Comment 2 Mark Hahnenberg 2013-10-23 13:53:27 PDT
Comment on attachment 214992 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-10-23 13:56:39 PDT
Landed in http://trac.webkit.org/changeset/157883