RESOLVED FIXED Bug 116189
FTL memory allocator should be able to allocate data sections in non-executable memory 
https://bugs.webkit.org/show_bug.cgi?id=116189
Summary FTL memory allocator should be able to allocate data sections in non-executab...
Filip Pizlo
Reported 2013-05-15 14:57:16 PDT
Patch forthcoming, eventually.
Attachments
the patch (4.98 KB, patch)
2013-10-07 15:22 PDT, Filip Pizlo 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-10-07 15:22:35 PDT
Created attachment 213621 [details] the patch
Sam Weinig
Comment 2 2013-10-07 15:27:35 PDT
Comment on attachment 213621 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=213621&action=review > Source/JavaScriptCore/ftl/FTLJITCode.h:61 > const Vector<RefPtr<ExecutableMemoryHandle> >& handles() const { return m_handles; } > + const Vector<RefCountedArray<LSectionWord> >& dataSections() const { return m_dataSections; } You don't need the space between the > >. > Source/JavaScriptCore/ftl/FTLJITCode.h:73 > + Vector<RefCountedArray<LSectionWord> > m_dataSections; > Vector<RefPtr<ExecutableMemoryHandle> > m_handles; You don't need the space between the > >.
Filip Pizlo
Comment 3 2013-10-07 15:44:30 PDT
(In reply to comment #2) > (From update of attachment 213621 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213621&action=review > > > Source/JavaScriptCore/ftl/FTLJITCode.h:61 > > const Vector<RefPtr<ExecutableMemoryHandle> >& handles() const { return m_handles; } > > + const Vector<RefCountedArray<LSectionWord> >& dataSections() const { return m_dataSections; } > > You don't need the space between the > >. > > > Source/JavaScriptCore/ftl/FTLJITCode.h:73 > > + Vector<RefCountedArray<LSectionWord> > m_dataSections; > > Vector<RefPtr<ExecutableMemoryHandle> > m_handles; > > You don't need the space between the > >. Fixed.
Filip Pizlo
Comment 4 2013-10-07 15:45:37 PDT
Landed in http://trac.webkit.org/changeset/157062
Note You need to log in before you can comment on or make changes to this bug.