Bug 116189 - FTL memory allocator should be able to allocate data sections in non-executable memory
Summary: FTL memory allocator should be able to allocate data sections in non-executab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840 122318
  Show dependency tree / graph
 
Reported: 2013-05-15 14:57 PDT by Filip Pizlo
Modified: 2013-10-07 15:45 PDT (History)
7 users (show)

See Also:

Attachments
the patch (4.98 KB, patch)
2013-10-07 15:22 PDT, Filip Pizlo 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-05-15 14:57:16 PDT 
Patch forthcoming, eventually.
Comment 1 Filip Pizlo 2013-10-07 15:22:35 PDT 
Created attachment 213621 [details]
the patch
Comment 2 Sam Weinig 2013-10-07 15:27:35 PDT 
Comment on attachment 213621 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213621&action=review

> Source/JavaScriptCore/ftl/FTLJITCode.h:61
>      const Vector<RefPtr<ExecutableMemoryHandle> >& handles() const { return m_handles; }
> +    const Vector<RefCountedArray<LSectionWord> >& dataSections() const { return m_dataSections; }

You don't need the space between the > >.

> Source/JavaScriptCore/ftl/FTLJITCode.h:73
> +    Vector<RefCountedArray<LSectionWord> > m_dataSections;
>      Vector<RefPtr<ExecutableMemoryHandle> > m_handles;

You don't need the space between the > >.
Comment 3 Filip Pizlo 2013-10-07 15:44:30 PDT 
(In reply to comment #2)
> (From update of attachment 213621 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213621&action=review
> 
> > Source/JavaScriptCore/ftl/FTLJITCode.h:61
> >      const Vector<RefPtr<ExecutableMemoryHandle> >& handles() const { return m_handles; }
> > +    const Vector<RefCountedArray<LSectionWord> >& dataSections() const { return m_dataSections; }
> 
> You don't need the space between the > >.
> 
> > Source/JavaScriptCore/ftl/FTLJITCode.h:73
> > +    Vector<RefCountedArray<LSectionWord> > m_dataSections;
> >      Vector<RefPtr<ExecutableMemoryHandle> > m_handles;
> 
> You don't need the space between the > >.

Fixed.
Comment 4 Filip Pizlo 2013-10-07 15:45:37 PDT 
Landed in http://trac.webkit.org/changeset/157062