RESOLVED FIXED 122287
Transition JITStubs functions to CCallHelper functions 
https://bugs.webkit.org/show_bug.cgi?id=122287
Summary Transition JITStubs functions to CCallHelper functions
Michael Saboff
Reported 2013-10-03 11:16:35 PDT
As part of our rolling over to C stack, we need to eliminate JITStubCall due to its reliance on JITStackFrame. The JITStubs should be eliminated or converted to functions called using CCallHelpers. -- Unused -- cti_op_is_boolean cti_op_is_number cti_op_is_string cti_op_is_undefined cti_op_resolve cti_op_resolve_base cti_op_resolve_base_strict_put cti_op_resolve_with_base cti_op_resolve_with_this cti_op_put_to_base cti_op_end -- Cached related functions -- cti_op_get_by_id_getter_stub cti_op_get_by_id cti_op_get_by_id_array_fail cti_op_get_by_id_custom_stub cti_op_get_by_id_generic cti_op_get_by_id_proto_fail cti_op_get_by_id_proto_list cti_op_get_by_id_proto_list_full cti_op_get_by_id_self_fail cti_op_get_by_id_string_fail cti_op_get_by_val cti_op_get_by_val_generic cti_op_get_by_val_string cti_op_put_by_id_transition_realloc cti_op_put_by_id cti_op_put_by_id_fail cti_op_put_by_id_generic cti_op_put_by_id_direct cti_op_put_by_id_direct_fail cti_op_put_by_id_direct_generic cti_op_put_by_val cti_op_put_by_val_generic -- Other functions -- cti_stack_check cti_op_call_arityCheck cti_op_construct_arityCheck cti_op_call_NotJSFunction cti_op_call_eval cti_op_construct_NotJSConstruct cti_op_check_has_instance cti_op_create_arguments cti_op_del_by_id cti_op_instanceof cti_to_object cti_op_new_array cti_op_new_array_with_size cti_op_new_array_buffer cti_op_new_func cti_op_new_func_exp cti_op_new_object cti_op_new_regexp cti_op_push_activation cti_op_push_name_scope cti_op_push_with_scope cti_op_get_pnames cti_op_eq cti_op_eq_strings cti_op_jless cti_op_jlesseq cti_op_jgreater cti_op_jgreatereq cti_op_jtrue cti_op_load_varargs cti_handle_watchdog_timer cti_has_property cti_op_debug cti_op_pop_scope cti_op_profile_did_call cti_op_profile_will_call cti_op_put_by_index cti_op_put_getter_setter cti_op_tear_off_activation cti_op_tear_off_arguments cti_optimize cti_op_call_jitCompile cti_op_construct_jitCompile cti_op_switch_char cti_op_switch_imm cti_op_switch_string cti_vm_lazyLinkCall cti_vm_lazyLinkClosureCall cti_vm_lazyLinkConstruct cti_op_resolve_scope cti_op_get_from_scope cti_op_put_to_scope cti_vm_handle_exception cti_vm_throw cti_op_throw cti_op_throw_static_error
Attachments
Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-10-09 11:18:05 PDT
Current state. Remaining stubs to convert: In progress and tracked with https://bugs.webkit.org/show_bug.cgi?id=122460 cti_op_new_array cti_op_new_array_with_size cti_op_new_array_buffer cti_op_new_func cti_op_new_func_exp cti_op_new_object In progress and tracked with https://bugs.webkit.org/show_bug.cgi?id=122563: cti_op_eq cti_op_eq_strings cti_op_jless cti_op_jlesseq cti_op_jgreater cti_op_jgreatereq cti_op_jtrue cti_has_property -- Cached related functions -- cti_op_get_by_id_getter_stub cti_op_get_by_id cti_op_get_by_id_array_fail cti_op_get_by_id_custom_stub cti_op_get_by_id_generic cti_op_get_by_id_proto_fail cti_op_get_by_id_proto_list cti_op_get_by_id_proto_list_full cti_op_get_by_id_self_fail cti_op_get_by_id_string_fail cti_op_get_by_val cti_op_get_by_val_generic cti_op_get_by_val_string cti_op_put_by_id_transition_realloc cti_op_put_by_id cti_op_put_by_id_fail cti_op_put_by_id_generic cti_op_put_by_id_direct cti_op_put_by_id_direct_fail cti_op_put_by_id_direct_generic cti_op_put_by_val cti_op_put_by_val_generic -- Other functions -- cti_op_check_has_instance cti_op_create_arguments cti_op_del_by_id cti_op_instanceof cti_to_object cti_op_push_activation cti_op_push_name_scope cti_op_push_with_scope cti_op_get_pnames cti_op_load_varargs cti_handle_watchdog_timer cti_op_debug cti_op_pop_scope cti_op_profile_did_call cti_op_profile_will_call cti_op_put_by_index cti_op_put_getter_setter cti_op_tear_off_activation cti_op_tear_off_arguments cti_optimize cti_op_call_jitCompile cti_op_construct_jitCompile cti_op_switch_char cti_op_switch_imm cti_op_switch_string cti_vm_lazyLinkCall cti_vm_lazyLinkClosureCall cti_vm_lazyLinkConstruct cti_op_resolve_scope cti_op_get_from_scope cti_op_put_to_scope cti_vm_handle_exception cti_vm_throw cti_op_throw cti_op_throw_static_error
Michael Saboff
Comment 2 2013-10-10 13:10:35 PDT
Transitioning the following - tracked by https://bugs.webkit.org/show_bug.cgi?id=122617 cti_handle_watchdog_timer cti_op_debug cti_op_pop_scope cti_op_profile_did_call cti_op_profile_will_call cti_op_put_by_index cti_op_put_getter_setter cti_op_tear_off_activation cti_op_tear_off_arguments cti_op_throw_static_error cti_optimize
Mark Lam
Comment 3 2013-10-11 08:29:05 PDT
Working on these next - tracked in https://bugs.webkit.org/show_bug.cgi?id=122645 cti_op_check_has_instance cti_op_create_arguments cti_op_del_by_id cti_op_instanceof cti_to_object cti_op_push_activation cti_op_push_name_scope cti_op_push_with_scope cti_op_get_pnames cti_op_load_varargs
Mark Lam
Comment 4 2013-10-14 09:54:37 PDT
https://bugs.webkit.org/show_bug.cgi?id=122757 Transitioning: cti_op_switch_char cti_op_switch_imm cti_op_switch_string cti_op_resolve_scope cti_op_get_from_scope cti_op_put_to_scope
Mark Lam
Comment 5 2013-10-14 09:59:19 PDT
Michael will handle these in https://bugs.webkit.org/show_bug.cgi?id=122758: cti_vm_handle_exception cti_vm_throw cti_op_throw
Mark Lam
Comment 6 2013-10-16 16:42:38 PDT
https://bugs.webkit.org/show_bug.cgi?id=122925 Transition: cti_op_get_by_id_generic cti_op_get_by_val cti_op_get_by_val_generic cti_op_get_by_val_string
Michael Saboff
Comment 7 2013-10-18 14:50:09 PDT
All stubs have been transitioned. Closing.
Note You need to log in before you can comment on or make changes to this bug.