RESOLVED FIXED 122903
transition void cti_op_put_by_val* stubs to JIT operations 
https://bugs.webkit.org/show_bug.cgi?id=122903
Summary transition void cti_op_put_by_val* stubs to JIT operations
Michael Saboff
Reported 2013-10-16 09:38:47 PDT
Transition cti_op_put_by_val and cti_op_put_by_val_generic to JIT Operations.
Attachments
Patch (22.28 KB, patch)
2013-10-16 16:03 PDT, Michael Saboff 		fpizlo: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch with fix for Release builds (22.41 KB, patch)
2013-10-16 17:22 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-10-16 16:03:46 PDT
Created attachment 214400 [details] Patch The callOperation in emitSlow_op_put_by_val() for X86 materializes the arguments due to not having the needed 6 temporary registers needed to use the corresponding callOperation(). When we free up our call frame register as another temporary, we can eliminate this X86 only code.
Geoffrey Garen
Comment 2 2013-10-16 16:09:32 PDT
Comment on attachment 214400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214400&action=review r=me > Source/JavaScriptCore/jit/JITOperations.cpp:544 > + Remove please.
EFL EWS Bot
Comment 3 2013-10-16 16:19:43 PDT
Comment on attachment 214400 [details] Patch Attachment 214400 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4111395
Build Bot
Comment 4 2013-10-16 16:32:52 PDT
Comment on attachment 214400 [details] Patch Attachment 214400 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3482426
Build Bot
Comment 5 2013-10-16 16:50:24 PDT
Comment on attachment 214400 [details] Patch Attachment 214400 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4107366
Michael Saboff
Comment 6 2013-10-16 17:22:07 PDT
Created attachment 214410 [details] Patch with fix for Release builds
Michael Saboff
Comment 7 2013-10-16 18:22:53 PDT
Committed r157546: <http://trac.webkit.org/changeset/157546>
Note You need to log in before you can comment on or make changes to this bug.