Bug 122757 – Transition *switch* and *scope* JITStubs to JIT operations

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Transitioning:
    cti_op_switch_char
    cti_op_switch_imm
    cti_op_switch_string
    cti_op_resolve_scope
    cti_op_get_from_scope
    cti_op_put_to_scope

[Mark Lam]

Created attachment 214202 [details]
the patch.

[Geoffrey Garen]

Comment on attachment 214202 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=214202&action=review

Needs some fixes before landing.

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1009
> +    ASSERT(returnValueRegister == regT0);
>      jump(regT0);

Please use returnValueRegister in the jump, and remove the ASSERT.

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1026
> +    ASSERT(returnValueRegister == regT0);
>      jump(regT0);

Ditto.

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1042
> +    ASSERT(returnValueRegister == regT0);
>      jump(regT0);

Ditto.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:695
> +    emitGetVirtualRegister(scrutinee, regT1);
> +    callOperation(operationSwitchImmWithUnknownKeyType, regT1, tableIndex);

This should be regT0.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:697
> +    ASSERT(returnValueRegister == regT0);
>      jump(regT0);

This should be returnValueRegister.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:712
> +    emitGetVirtualRegister(scrutinee, regT1);
> +    callOperation(operationSwitchCharWithUnknownKeyType, regT1, tableIndex);

regT0.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:714
> +    ASSERT(returnValueRegister == regT0);
>      jump(regT0);

returnValueRegister.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:730
> +    emitGetVirtualRegister(scrutinee, regT1);
> +    callOperation(operationSwitchStringWithUnknownKeyType, regT1, tableIndex);
> +    ASSERT(returnValueRegister == regT0);
>      jump(regT0);

Ditto.

[Mark Lam]

Thanks for the review.  Remaining issues have been fixed.  Landed in r157439: <http://trac.webkit.org/r157439>.