Bug 120847 – [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gábor Ábrahám]

The whole force repaint code should be in if (PlatformWebView::windowShapshotEnabled()) block, as the previous Qt implementation.

[Gábor Ábrahám]

Created attachment 210723 [details]
proposed fix

[Csaba Osztrogonác]

Comment on attachment 210723 [details]
proposed fix

LGTM, r=me.

[Csaba Osztrogonác]

Comment on attachment 210723 [details]
proposed fix

Clearing flags on attachment: 210723

Committed r155188: <http://trac.webkit.org/changeset/155188>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 210723 [details]:

http/tests/inspector/inspect-element.html bug 78869 (author: [e-mail])
ietestcenter/css3/grid/grid-column-002.htm bug 120851 (authors: [e-mail], [e-mail], and [e-mail])
ietestcenter/css3/multicolumn/column-width-applies-to-004.htm bug 120852 (author: [e-mail])
ietestcenter/css3/multicolumn/column-width-applies-to-014.htm bug 120853 (author: [e-mail])
ietestcenter/css3/multicolumn/column-containing-block-003.htm bug 120854 (author: [e-mail])
ietestcenter/css3/multicolumn/column-width-applies-to-003.htm bug 120855 (author: [e-mail])
ietestcenter/css3/multicolumn/column-width-applies-to-002.htm bug 120856 (author: [e-mail])
ietestcenter/css3/multicolumn/column-width-applies-to-013.htm bug 120857 (author: [e-mail])
ietestcenter/css3/multicolumn/column-width-applies-to-001.htm bug 120858 (author: [e-mail])
ietestcenter/css3/multicolumn/column-block-formatting-context-001.htm bug 120859 (author: [e-mail])
fast/regions/counters/extract-list-items-006.html bug 120736 (author: [e-mail])
fast/regions/counters/extract-list-items-015.html bug 120737 (author: [e-mail])
fast/regions/counters/extract-numbered-paragraphs-divs-002.html bug 120738 (author: [e-mail])
fast/regions/counters/extract-list-items-003.html bug 120739 (author: [e-mail])
fast/regions/counters/extract-list-items-001.html bug 120740 (author: [e-mail])
fast/regions/counters/extract-list-items-013.html bug 120741 (author: [e-mail])
fast/regions/counters/extract-list-items-014.html bug 120742 (author: [e-mail])
fast/shapes/shape-outside-floats/shape-outside-floats-image-002.html bug 120753 (author: [e-mail])
fast/shapes/shape-outside-floats/shape-outside-floats-image-001.html bug 120754 (author: [e-mail])
fast/multicol/newmulticol/float-paginate.html bug 120744 (author: [e-mail])
fast/multicol/newmulticol/columns-shorthand-parsing.html bug 120745
fast/multicol/newmulticol/float-paginate-complex.html bug 120746 (author: [e-mail])
fast/multicol/newmulticol/direct-child-column-span-all.html bug 120747 (author: [e-mail])
fast/multicol/newmulticol/column-rules-fixed-height.html bug 120748 (author: [e-mail])
fast/multicol/newmulticol/positioned-split.html bug 120749 (author: [e-mail])
fast/multicol/newmulticol/layers-in-multicol.html bug 120750 (author: [e-mail])
fast/multicol/newmulticol/positioned-with-constrained-height.html bug 120751 (author: [e-mail])
loader/go-back-to-different-window-size.html bug 114274 (authors: [e-mail] and [e-mail])
svg/text/add-tspan-position-bug.html bug 120860 (authors: [e-mail] and [e-mail])
animations/cross-fade-background-image.html bug 120755 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.