Bug 120715 - Expected result images are sometimes blank in WKTR
Summary: Expected result images are sometimes blank in WKTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 120843 120847
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-04 18:24 PDT by Simon Fraser (smfr)
Modified: 2013-09-18 22:33 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.18 KB, patch)
2013-09-04 18:29 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Fix the other platforms (6.66 KB, patch)
2013-09-05 11:49 PDT, Simon Fraser (smfr)
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-09-04 18:24:52 PDT
Expected result images are sometimes blank in WKTR
Comment 1 Simon Fraser (smfr) 2013-09-04 18:29:02 PDT
Created attachment 210534 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-09-04 18:29:30 PDT
<rdar://problem/14382142>
Comment 3 Early Warning System Bot 2013-09-04 18:45:10 PDT
Comment on attachment 210534 [details]
Patch

Attachment 210534 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1703017
Comment 4 Tim Horton 2013-09-04 19:17:32 PDT
Comment on attachment 210534 [details]
Patch

Seems reasonable to me, though I wonder if we shouldn't maybe do something cross-platform since everyone is doing this.
Comment 5 EFL EWS Bot 2013-09-04 19:28:15 PDT
Comment on attachment 210534 [details]
Patch

Attachment 210534 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1693808
Comment 6 Simon Fraser (smfr) 2013-09-05 11:49:46 PDT
Created attachment 210641 [details]
Fix the other platforms
Comment 7 Simon Fraser (smfr) 2013-09-05 12:34:47 PDT
Comment on attachment 210641 [details]
Fix the other platforms

Carry Tim's review forward.
Comment 8 Simon Fraser (smfr) 2013-09-05 12:38:08 PDT
https://trac.webkit.org/r155140
Comment 9 Ryosuke Niwa 2013-09-18 19:08:48 PDT
It seems like this patch caused media/video-object-fit.html to fail on Lion WK2 builders:
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-object-fit.html
Comment 10 Alexey Proskuryakov 2013-09-18 22:33:00 PDT
media/video-object-fit.html is flaky everywhere.