Bug 120843 - REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
Summary: REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks: 120715
  Show dependency tree / graph
 
Reported: 2013-09-06 03:29 PDT by Allan Sandfeld Jensen
Modified: 2013-09-06 08:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2013-09-06 03:36 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-09-06 03:29:23 PDT 
The new common implementatino of forceRepaintDoneCallback is missing the important notifyDone() callback which the non-Apple ports use.
Comment 1 Gábor Ábrahám 2013-09-06 03:34:42 PDT 
I'm on it, I have the fix soon.
Comment 2 Allan Sandfeld Jensen 2013-09-06 03:36:00 PDT 
Created attachment 210718 [details]
Patch
Comment 3 Gábor Ábrahám 2013-09-06 03:46:06 PDT 
I found another bug, I will upload the fix soon.
Comment 4 Gábor Ábrahám 2013-09-06 03:50:31 PDT 
Additionally the whole force repaint code should be in if (PlatformWebView::windowShapshotEnabled()) block, as the previous Qt implementation.
By the way I think it should be windowSnapshotEnabled.
Comment 5 Csaba Osztrogonác 2013-09-06 03:53:34 PDT 
Comment on attachment 210718 [details]
Patch

LGTM, r=me
Comment 6 Csaba Osztrogonác 2013-09-06 03:54:42 PDT 
(In reply to comment #4)
> Additionally the whole force repaint code should be in if (PlatformWebView::windowShapshotEnabled()) block, as the previous Qt implementation.
> By the way I think it should be windowSnapshotEnabled.

Nice catch. I think it can be done in a separated 
patch. Could you file a bug report and upload your fix?
Comment 7 WebKit Commit Bot 2013-09-06 05:06:47 PDT 
Comment on attachment 210718 [details]
Patch

Clearing flags on attachment: 210718

Committed r155187: <http://trac.webkit.org/changeset/155187>
Comment 8 WebKit Commit Bot 2013-09-06 05:06:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Simon Fraser (smfr) 2013-09-06 08:54:06 PDT 
Sorry about that. It wasn't obvious to me whether the notifyDone was needed.