Bug 119756 - [CSS Grid Layout] Handle 'span' positions during layout
Summary: [CSS Grid Layout] Handle 'span' positions during layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
: 115404 (view as bug list)
Depends on: 118051 119801
Blocks: 60731 103314 119540
  Show dependency treegraph
 
Reported: 2013-08-13 10:25 PDT by Sergio Villar Senin
Modified: 2013-11-06 08:40 PST (History)
7 users (show)

See Also:


Attachments
Patch (14.23 KB, patch)
2013-08-28 04:15 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff
Patch (14.12 KB, patch)
2013-08-28 09:15 PDT, Sergio Villar Senin
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-08-13 10:25:30 PDT
In bug 118051 we added support for the 'span' keyword at parser level. This change effectively uses it to perform the final layout of the grid items. This has been already implemented in Blink. 

We should probably merge:

    r149133
    Properly handle 'span' position during layout
    
    This change plumbs the final bits so that we now recognize 'span'
    positions and resolve them accordingly.
Comment 1 Sergio Villar Senin 2013-08-28 04:15:44 PDT
Created attachment 209864 [details]
Patch
Comment 2 Sergio Villar Senin 2013-08-28 09:15:32 PDT
Created attachment 209894 [details]
Patch
Comment 3 Sergio Villar Senin 2013-08-28 09:48:09 PDT
Committed r154753: <http://trac.webkit.org/changeset/154753>
Comment 4 Sergio Villar Senin 2013-11-06 08:40:08 PST
*** Bug 115404 has been marked as a duplicate of this bug. ***