Bug 119540 – [CSS Grid Layout] Add parsing for named grid lines

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Sergio Villar Senin]

We added support for parsing named grid lines at <trac-list> level, i.e. in the definition of the grid. Now we should add support to parsing grid lines at <grid-line> level, i.e. inside grid-{row|column}-{start|end}. This change covers only the parsing, the layout changes are coming in a follow up patch.

We should consider merging these two changes in Blink instead of starting from scratch:

    r150381
    Add parsing for named grid lines

    This extends our grammar to support named grid lines (no support
    for named grid lines with 'span' yet, though the testing for that
    is added as part of this change).

and

    r150587
    Add parsing for named grid lines with 'span'

    This change extends our grammar to support all types of named grid
    lines (the current code would only support grid lines without the
    'span' keyword). This means that grid-start: span 1 'first' will now
    be properly parsed (but not resolved for layout which will be done in
    a follow-up change).

[Sergio Villar Senin]

Created attachment 209898 [details]
Patch

[Early Warning System Bot]

Comment on attachment 209898 [details]
Patch

Attachment 209898 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1618325

[Early Warning System Bot]

Comment on attachment 209898 [details]
Patch

Attachment 209898 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1581649

[EFL EWS Bot]

Comment on attachment 209898 [details]
Patch

Attachment 209898 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1625291

[EFL EWS Bot]

Comment on attachment 209898 [details]
Patch

Attachment 209898 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1622272

[Build Bot]

Comment on attachment 209898 [details]
Patch

Attachment 209898 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1591616

[Build Bot]

Comment on attachment 209898 [details]
Patch

Attachment 209898 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1626281

[Sergio Villar Senin]

Created attachment 209903 [details]
Patch

[Andreas Kling]

Comment on attachment 209903 [details]
Patch

r=me

[Sergio Villar Senin]

Committed r154996: <http://trac.webkit.org/changeset/154996>