Bug 119632 - [CSS Grid Layout] Resolve named grid lines
Summary: [CSS Grid Layout] Resolve named grid lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
Depends on: 119540
Blocks: 103310
  Show dependency treegraph
 
Reported: 2013-08-09 08:27 PDT by Sergio Villar Senin
Modified: 2013-09-06 01:03 PDT (History)
8 users (show)

See Also:


Attachments
Patch (25.86 KB, patch)
2013-09-04 09:40 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-08-09 08:27:27 PDT
The patch for bug 119540 will add parsing support for named grid lines. That's the first step, after that we need to use that information to properly position the different elements in the grid.

This was done in Blink in:

   r152659
   Properly resolve named grid lines

   This change adds the code to convert from a raw named grid line
   (stored in RenderStyle) to its actual grid position.

and

   r153794
   [CSS Grid Layout] Support named grid lines with 'span'

   This change implements the resolution for named grid lines with 'span',
   which is the missing piece to fully support named grid lines.
Comment 1 Sergio Villar Senin 2013-09-04 09:40:27 PDT
Created attachment 210471 [details]
Patch
Comment 2 Sergio Villar Senin 2013-09-06 01:03:37 PDT
Comment on attachment 210471 [details]
Patch

Clearing flags on attachment: 210471

Committed r155181: <http://trac.webkit.org/changeset/155181>
Comment 3 Sergio Villar Senin 2013-09-06 01:03:44 PDT
All reviewed patches have been landed.  Closing bug.