Bug 118716 - [EFL][WK2] Relevant test classes should be redefined by inheriting from EWK2UnitTestBase as per each test file
Summary: [EFL][WK2] Relevant test classes should be redefined by inheriting from EWK2U...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 118717 118721 118726 118762 118763 118766 118767 118769 118771 118772 118773 118775 118777 118779 118780
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-16 00:25 PDT by Donggwan Kim
Modified: 2013-07-17 03:50 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Donggwan Kim 2013-07-16 00:25:12 PDT
All the test files use EWK2UnitTestBase only.
There are many methods and variables defined in each test file as static.
It should be defined as relevant test class specific to each test file for more readability like below.

class EWK2FooTest : public EWK2UnitTestBase {
public:
    void foo();
};
Comment 1 Donggwan Kim 2013-07-16 01:01:17 PDT
I uploaded the patch as sample. (https://bugs.webkit.org/show_bug.cgi?id=118717)
If this approach is accepted by a reviewer, i will modify all other test cases as well.
Comment 2 Donggwan Kim 2013-07-17 03:50:56 PDT
All the dependent patches was fixed and closed.