RESOLVED FIXED 118716
[EFL][WK2] Relevant test classes should be redefined by inheriting from EWK2UnitTestBase as per each test file
https://bugs.webkit.org/show_bug.cgi?id=118716
Summary [EFL][WK2] Relevant test classes should be redefined by inheriting from EWK2U...
Donggwan Kim
Reported 2013-07-16 00:25:12 PDT
All the test files use EWK2UnitTestBase only. There are many methods and variables defined in each test file as static. It should be defined as relevant test class specific to each test file for more readability like below. class EWK2FooTest : public EWK2UnitTestBase { public: void foo(); };
Attachments
Donggwan Kim
Comment 1 2013-07-16 01:01:17 PDT
I uploaded the patch as sample. (https://bugs.webkit.org/show_bug.cgi?id=118717) If this approach is accepted by a reviewer, i will modify all other test cases as well.
Donggwan Kim
Comment 2 2013-07-17 03:50:56 PDT
All the dependent patches was fixed and closed.
Note You need to log in before you can comment on or make changes to this bug.