Bug 118721 - [EFL][WK2] EWK2CookieManagerTest should be defined by inheriting from EWK2UnitTestBase.
Summary: [EFL][WK2] EWK2CookieManagerTest should be defined by inheriting from EWK2Uni...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 118716
  Show dependency treegraph
 
Reported: 2013-07-16 01:48 PDT by Donggwan Kim
Modified: 2013-07-17 01:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.98 KB, patch)
2013-07-16 02:50 PDT, Donggwan Kim
no flags Details | Formatted Diff | Diff
Patch (6.15 KB, patch)
2013-07-16 04:23 PDT, Donggwan Kim
no flags Details | Formatted Diff | Diff
Patch (9.53 KB, patch)
2013-07-16 04:35 PDT, Donggwan Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Donggwan Kim 2013-07-16 01:48:21 PDT
Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717
Comment 1 Donggwan Kim 2013-07-16 02:50:40 PDT
Created attachment 206746 [details]
Patch
Comment 2 Chris Dumez 2013-07-16 02:56:19 PDT
Comment on attachment 206746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206746&action=review

> Source/WebKit2/ChangeLog:7
> +

Missing Changelog.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:85
> +static int compareHostNames(const void* hostName1, const void* hostName2)

Could you explain why some static functions are moved to EWK2CookieManagerTest while others are not?
Comment 3 Donggwan Kim 2013-07-16 04:23:37 PDT
Created attachment 206759 [details]
Patch
Comment 4 Donggwan Kim 2013-07-16 04:33:15 PDT
(In reply to comment #2)
> (From update of attachment 206746 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206746&action=review
> 
> > Source/WebKit2/ChangeLog:7
> > +
> 
> Missing Changelog.
Done.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:85
> > +static int compareHostNames(const void* hostName1, const void* hostName2)
> 
> Could you explain why some static functions are moved to EWK2CookieManagerTest while others are not?
I made a mistake. I will move all the missed static functions to EWK2CookieManagerTest and update the patch again.
Comment 5 Donggwan Kim 2013-07-16 04:35:21 PDT
Created attachment 206761 [details]
Patch
Comment 6 Chris Dumez 2013-07-16 04:42:27 PDT
Comment on attachment 206761 [details]
Patch

Ok, r=me.
Comment 7 WebKit Commit Bot 2013-07-17 01:47:42 PDT
Comment on attachment 206761 [details]
Patch

Clearing flags on attachment: 206761

Committed r152776: <http://trac.webkit.org/changeset/152776>
Comment 8 WebKit Commit Bot 2013-07-17 01:47:45 PDT
All reviewed patches have been landed.  Closing bug.