RESOLVED FIXED 118717
[EFL][WK2] EWK2BackForwardListTest should be defined by inheriting from EWK2UnitTestBase 
https://bugs.webkit.org/show_bug.cgi?id=118717
Summary [EFL][WK2] EWK2BackForwardListTest should be defined by inheriting from EWK2U...
Donggwan Kim
Reported 2013-07-16 00:28:41 PDT
Please refer to https://bugs.webkit.org/show_bug.cgi?id=118716 for more information about this patch
Attachments
Patch (5.79 KB, patch)
2013-07-16 00:58 PDT, Donggwan Kim 		no flags
DetailsFormatted DiffDiff
Patch (5.84 KB, patch)
2013-07-16 01:18 PDT, Donggwan Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Donggwan Kim
Comment 1 2013-07-16 00:58:40 PDT
Created attachment 206735 [details] Patch
Chris Dumez
Comment 2 2013-07-16 01:07:42 PDT
Comment on attachment 206735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206735&action=review r=me with nits. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:63 > + inline void checkItem(Ewk_Back_Forward_List_Item* item, const char* title, const char* url, const char* originalURL) Please remove the "inline" here and below. They likely don't bring anything here since the methods are implemented in the body of the class declaration.
Donggwan Kim
Comment 3 2013-07-16 01:18:19 PDT
Created attachment 206737 [details] Patch
WebKit Commit Bot
Comment 4 2013-07-16 04:09:45 PDT
Comment on attachment 206737 [details] Patch Clearing flags on attachment: 206737 Committed r152713: <http://trac.webkit.org/changeset/152713>
WebKit Commit Bot
Comment 5 2013-07-16 04:09:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.