Bug 118726 - [EFL][WK2] EWK2DatabaseManagerTest should be defined by inheriting from EWK2UnitTestBase
Summary: [EFL][WK2] EWK2DatabaseManagerTest should be defined by inheriting from EWK2U...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 118716
  Show dependency treegraph
 
Reported: 2013-07-16 03:53 PDT by Donggwan Kim
Modified: 2013-07-17 00:04 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.73 KB, patch)
2013-07-16 03:55 PDT, Donggwan Kim
no flags Details | Formatted Diff | Diff
Patch (5.90 KB, patch)
2013-07-16 04:16 PDT, Donggwan Kim
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (557.02 KB, application/zip)
2013-07-16 08:38 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Donggwan Kim 2013-07-16 03:53:24 PDT
Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717
Comment 1 Donggwan Kim 2013-07-16 03:55:34 PDT
Created attachment 206751 [details]
Patch
Comment 2 Chris Dumez 2013-07-16 04:02:46 PDT
Comment on attachment 206751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206751&action=review

> Source/WebKit2/ChangeLog:7
> +

Missing Changelog.
Comment 3 Donggwan Kim 2013-07-16 04:16:47 PDT
Created attachment 206756 [details]
Patch
Comment 4 Donggwan Kim 2013-07-16 04:19:29 PDT
(In reply to comment #2)
> (From update of attachment 206751 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206751&action=review
> 
> > Source/WebKit2/ChangeLog:7
> > +
> 
> Missing Changelog.
Done
Comment 5 Donggwan Kim 2013-07-16 04:38:53 PDT
Comment on attachment 206756 [details]
Patch

Done
Comment 6 Chris Dumez 2013-07-16 04:43:50 PDT
Comment on attachment 206756 [details]
Patch

Ok, r=me.
Comment 7 Build Bot 2013-07-16 08:38:31 PDT
Comment on attachment 206756 [details]
Patch

Attachment 206756 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1088203

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html
Comment 8 Build Bot 2013-07-16 08:38:33 PDT
Created attachment 206785 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 9 Donggwan Kim 2013-07-16 18:26:05 PDT
I don't think it is not related to this patch because this patch affect EFL WebKit2 API Test only.
Comment 10 Ryuan Choi 2013-07-16 18:37:54 PDT
(In reply to comment #9)
> I don't think it is not related to this patch because this patch affect EFL WebKit2 API Test only.

I think that you should get r+ again because you cleared it. :)
Comment 11 WebKit Commit Bot 2013-07-17 00:04:24 PDT
Comment on attachment 206756 [details]
Patch

Clearing flags on attachment: 206756

Committed r152759: <http://trac.webkit.org/changeset/152759>
Comment 12 WebKit Commit Bot 2013-07-17 00:04:28 PDT
All reviewed patches have been landed.  Closing bug.