Bug 118726 – [EFL][WK2] EWK2DatabaseManagerTest should be defined by inheriting from EWK2UnitTestBase

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Donggwan Kim]

Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717

[Donggwan Kim]

Created attachment 206751 [details]
Patch

[Chris Dumez]

Comment on attachment 206751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206751&action=review

> Source/WebKit2/ChangeLog:7
> +

Missing Changelog.

[Donggwan Kim]

Created attachment 206756 [details]
Patch

[Donggwan Kim]

(In reply to comment #2)
> (From update of attachment 206751 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206751&action=review
> 
> > Source/WebKit2/ChangeLog:7
> > +
> 
> Missing Changelog.
Done

[Donggwan Kim]

Comment on attachment 206756 [details]
Patch

Done

[Chris Dumez]

Comment on attachment 206756 [details]
Patch

Ok, r=me.

[Build Bot]

Comment on attachment 206756 [details]
Patch

Attachment 206756 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1088203

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html

[Build Bot]

Created attachment 206785 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Donggwan Kim]

I don't think it is not related to this patch because this patch affect EFL WebKit2 API Test only.

[Ryuan Choi]

(In reply to comment #9)
> I don't think it is not related to this patch because this patch affect EFL WebKit2 API Test only.

I think that you should get r+ again because you cleared it. :)

[WebKit Commit Bot]

Comment on attachment 206756 [details]
Patch

Clearing flags on attachment: 206756

Committed r152759: <http://trac.webkit.org/changeset/152759>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.