Bug 107386 - [SVG2] Merge SVGStyledElement and SVGElement
Summary: [SVG2] Merge SVGStyledElement and SVGElement
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: BlinkMergeCandidate, WebExposed
Depends on: 106877 118408 118474 120155
Blocks: 108665
  Show dependency treegraph
Reported: 2013-01-19 17:24 PST by Philip Rogers
Modified: 2013-08-22 14:57 PDT (History)
25 users (show)

See Also:

Patch (225.36 KB, patch)
2013-08-22 07:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (225.62 KB, patch)
2013-08-22 08:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2013-01-19 17:24:23 PST
SVG2 updates the class hierarchy so all SVGElements are styled. We should merge SVGStyledElement into SVGElement.

SVG2 updated spec for SVGElement:

A comparison of SVG 1.1 and SVG 2:
Comment 1 Chris Dumez 2013-07-31 23:07:44 PDT
Corresponding Blink revision:
Comment 3 Chris Dumez 2013-08-22 07:32:24 PDT
Created attachment 209365 [details]
Comment 4 Build Bot 2013-08-22 08:03:02 PDT
Comment on attachment 209365 [details]

Attachment 209365 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1538110
Comment 5 Chris Dumez 2013-08-22 08:13:56 PDT
Created attachment 209369 [details]
Comment 6 Andreas Kling 2013-08-22 08:50:16 PDT
Comment on attachment 209369 [details]

Comment 7 Chris Dumez 2013-08-22 10:06:41 PDT
I will wait a bit to land in case an SVG specialist wants to take a look as well. However, I do not wish to wait too long as the patch is huge and would be a pain to rebase.

Please let me know.
Comment 8 Philip Rogers 2013-08-22 14:30:15 PDT
This also looks good to me. R+!
Comment 9 WebKit Commit Bot 2013-08-22 14:57:07 PDT
Comment on attachment 209369 [details]

Clearing flags on attachment: 209369

Committed r154462: <http://trac.webkit.org/changeset/154462>
Comment 10 WebKit Commit Bot 2013-08-22 14:57:12 PDT
All reviewed patches have been landed.  Closing bug.